399556 - cairo_scaled_font_destroy: Assertion `scaled_font->ref_count > 0' failed.

Status: RESOLVED FIXED

Description

[Reed Loden [:reed] (use needinfo?)]

I've been continually getting shutdown crashes with the following error:
firefox-bin: /build/buildd/libcairo-1.4.10/src/cairo-scaled-font.c:617: cairo_scaled_font_destroy: Assertion `scaled_font->ref_count > 0' failed.

Breakpad IDs:
* bp-5c351700-7815-11dc-8210-001a4bd43ef6
* bp-89bef55e-7880-11dc-b8f4-001a4bd43e5c

Comment 1

[Stuart Parmenter]

we should probably not call cairo_debug_reset_static_data in opt builds..

Comment 2

[Stuart Parmenter]

Created attachment 285921 [details] [diff] [review]
fix

this should disable it in non-test builds

Comment 3

[Karl Tomlinson (:karlt)]

(In reply to comment #2)
> Created an attachment (id=285921) [details]
> fix
> 
> this should disable it in non-test builds
> 

I wonder if that should be disabled for system cairo too (as we'd be sharing the cairo).

To work-around this crash we may need to do the same here:

http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/gfx/thebes/src/gfxPangoFonts.cpp&rev=1.109&mark=219-221#215

Comment 4

[Reed Loden [:reed] (use needinfo?)]

Comment on attachment 285921 [details] [diff] [review]
fix

This partly fixes a shutdown crash that I hit almost every day or every other day.

Comment 5

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 285921 [details] [diff] [review]
fix

a=endgame drivers for M9

Comment 6

[Stuart Parmenter]

checked in.

Comment 7

[Karl Tomlinson (:karlt)]

This is still showing up in latest builds:

http://crash-stats.mozilla.com/report/list?range_unit=weeks&version=Firefox%3A3.0a9pre&range_value=2&signature=%400xffffe410
http://crash-stats.mozilla.com/report/list?range_unit=weeks&version=Firefox%3A3.0a9pre&range_value=2&signature=libc-2.6.1.so%400x2a7d6

Comment 8

[Reed Loden [:reed] (use needinfo?)]

This should be a beta blocker, imho. I think this is how to nominate?

Comment 9

[Damon Sicore (:damons)]

That'll work, Reed.  

Comment 10

[Stuart Parmenter]

I don't think this should block beta unless something bad is happening as a result of the crash.

That said, I don't see how we would be calling that function with that set of ifdefs given the logs from the nightly builds.

Comment 11

[Stuart Parmenter]

While I don't think it should block, if we can find a fix shortly, we should probably land it for M9.

Comment 12

[Karl Tomlinson (:karlt)]

Created attachment 286600 [details] [diff] [review]
don't pango_fc_font_map_shutdown in release builds

(gtk may still be using the fontmap so I wonder whether we should not shut this down until after closing the display.)

Comment 13

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 286600 [details] [diff] [review]
don't pango_fc_font_map_shutdown in release builds

a=endgame drivers for M9

Comment 14

[Karl Tomlinson (:karlt)]

gfxPangoFonts.cpp revision 1.110.

Comment 15

[Marcia Knous [:marcia - use ni]]

Reed: Since you have been seeing this crash, would you mind checking the latest nightly to see if you are still seeing it? Thanks.

Comment 16

[Daniel Holbert [:dholbert]]

I still get this abort & crash in Linux debug builds, but not in release builds.  See bug 402785.