Closed
Bug 399599
Opened 18 years ago
Closed 17 years ago
Help menu has no accesskey for item "Contents"
Categories
(Calendar :: Sunbird Only, defect)
Calendar
Sunbird Only
Tracking
(Not tracked)
VERIFIED
FIXED
0.9
People
(Reporter: grillo_n, Assigned: ssitter)
Details
Attachments
(1 file, 1 obsolete file)
2.56 KB,
patch
|
ssitter
:
review+
|
Details | Diff | Splinter Review |
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.0; pt-BR; rv:1.8.1.7) Gecko/20070914 Firefox/2.0.0.7
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.0; pt-BR; rv:1.8.1.8pre) Gecko/20071011 Sunbird/0.7
Hi.
In the file chrome/calendar/calendar.dtd, the entity calendar.help.label "Help Contents" (line 279) doesn't have an associated accesskey entity.
I realize there are no help contents anyway, but there seems to be no need for the accesskey to wait for the contents (just in case someone asks).
Thanks,
Emerson
Reproducible: Always
Updated•18 years ago
|
Severity: normal → minor
Status: UNCONFIRMED → NEW
Ever confirmed: true
OS: Windows 2000 → All
Hardware: PC → All
Summary: Sunbird Help menu has no accesskey for item "Contents" → Help menu has no accesskey for item "Contents"
Assignee | ||
Comment 1•17 years ago
|
||
Comment 2•17 years ago
|
||
Comment on attachment 304757 [details] [diff] [review]
add accesskey
>Index: mozilla/calendar/locales/en-US/chrome/calendar/calendar.dtd
>===================================================================
> [...]
> <!ENTITY calendarproperties.readonly.label "Read Only">
> <!ENTITY calendarproperties.firealarms.label "Show Alarms">
> <!ENTITY calendarproperties.cache.label "Cache (EXPERIMENTAL, requires restart)">
>
> <!-- Sunbird Help -->
>-<!ENTITY calendar.help.label "Help Contents">
>+<!ENTITY calendar.help.label "Help Contents">
>+<!ENTITY calendar.help.accesskey "H">
I'd prefer it, if you would leave the indentation as it is right now and the accesskey string indented the same way.
r=sipaq, with that changed.
Attachment #304757 -
Flags: review?(bugzilla) → review+
Updated•17 years ago
|
Severity: minor → trivial
Keywords: checkin-needed
Whiteboard: [checkin needed after 0.8]
Target Milestone: --- → 0.9
Assignee | ||
Comment 3•17 years ago
|
||
same patch as before but keep random indentation; carry over r=sipaq
Attachment #304757 -
Attachment is obsolete: true
Attachment #305547 -
Flags: review+
Comment 4•17 years ago
|
||
Checked in on HEAD and MOZILLA_1_8_BRANCH
-> FIXED
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Whiteboard: [checkin needed after 0.8]
You need to log in
before you can comment on or make changes to this bug.
Description
•