399794 - Remove the use of Atoms of nsIconURI

Status: VERIFIED FIXED

(Core :: Graphics: ImageLib, defect)

Description

[Alfred Kayser]

Attachment: V1: Replace all that Atom overhead with some PL_strcasecmp's.

Remove the use of Atoms of nsIconURI, as they are only used to save some strcmp's. It is for these few strcmp's to just do that instead of calling into the AtomService with all that overhead. 
In total this about 15K code (measured on FF-optimized build), and remove dependency to the Atom service, and uses less memory. (the strings are now really static data, and no Atoms are created).

Note, can 'stricmp' be used instead of PL_strcasecmp?

Comment 1

[Alfred Kayser]

Reed, can you do the checkin for me?
Thanks in advance, Alfred

Comment 2

[Reed Loden [:reed]]

Checking in modules/libpr0n/decoders/icon/nsIconModule.cpp;
/cvsroot/mozilla/modules/libpr0n/decoders/icon/nsIconModule.cpp,v  <--  nsIconModule.cpp
new revision: 1.11; previous revision: 1.10
done
Checking in modules/libpr0n/decoders/icon/nsIconURI.cpp;
/cvsroot/mozilla/modules/libpr0n/decoders/icon/nsIconURI.cpp,v  <--  nsIconURI.cpp
new revision: 1.29; previous revision: 1.28
done
Checking in modules/libpr0n/decoders/icon/nsIconURI.h;
/cvsroot/mozilla/modules/libpr0n/decoders/icon/nsIconURI.h,v  <--  nsIconURI.h
new revision: 1.12; previous revision: 1.11
done

Comment 3

[Alfred Kayser]

Thanks!

libimgicon.so
  	Total:	       -688 (+941/-1629)
  	Code:	       -586 (+0/+0)
  	Data:	       -102 (+941/-1629)