Closed
Bug 399809
Opened 17 years ago
Closed 17 years ago
Trim down Sunbird build
Categories
(Calendar :: Sunbird Only, defect)
Calendar
Sunbird Only
Tracking
(Not tracked)
VERIFIED
FIXED
0.8
People
(Reporter: sipaq, Assigned: sipaq)
Details
Attachments
(1 file, 1 obsolete file)
1.12 KB,
patch
|
dbo
:
review+
|
Details | Diff | Splinter Review |
The following files are not needed for Sunbird and should be removed from the build to reduce our Sunbird download size: - All dictionaries - nsSetDefaultBrowser.js - nsSetDefaultMail.js - nsUnsetDefaultMail.js The dictionaries are currently only packaged on the trunk and add 238K to our download package on Windows. The three other files are only added on the branch and add 8K to our download package on Windows. I have not added those files to removed-files.in, because that file already contained entries for those files.
Attachment #284871 -
Flags: review?(ctalbert)
Comment 1•17 years ago
|
||
I think that we do want to pack dictionaries. Spellchecking is a nice feature. And as long as dictionaries can't be shared with other mozilla apps, we have to ship them... (I don't know if spellchecking actually works at the moment, but if it doesn't, it is a bug)
Assignee | ||
Comment 2•17 years ago
|
||
Since I do not consider our app to be as text-heavy as a mail client, a HTML editor or a browser, I thought it best to leave out the dictionaries. The footprint cost is not worth the additional benefit IMO.
Comment 3•17 years ago
|
||
I agree with mvl. Even though we are not as text-heavy as other apps, I still think that spellchecking is a useful feature. Lets say you are in a company, inviting attendees to meetings. It may be embarrassing if you spell obvious words wrong, you will want spellchecking. I don't think spellchecking works right now though, also we don't have toolbar buttons to change dictionaries and such. Sunbird is not *that* large, what is it, 7 mb? I think thats a reasonable size given that many users today have broadband. Non-broadband users are used to waiting.
Comment 4•17 years ago
|
||
The dictionaries were added with Bug 350055 because they belong to toolkit. Don't forget that linux and mac package would still ship the files. In this case we should be consistent and ship them on win32 too. After all: The win32 installer package is only about 4.9 MB compared to 8.2 MB for linux resp. 14 MB for mac os x.
Assignee | ||
Comment 5•17 years ago
|
||
Attachment #284871 -
Attachment is obsolete: true
Attachment #288227 -
Flags: review?(daniel.boelzle)
Attachment #284871 -
Flags: review?(ctalbert)
Comment 6•17 years ago
|
||
Comment on attachment 288227 [details] [diff] [review] Patch v2 (incorporating mvl's and Philipp's comments) r=dbo
Attachment #288227 -
Flags: review?(daniel.boelzle) → review+
Assignee | ||
Comment 7•17 years ago
|
||
Patch checked in on HEAD and MOZILLA_1_8_BRANCH.
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
Assignee | ||
Updated•17 years ago
|
Target Milestone: --- → 0.8
Updated•16 years ago
|
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•