399813 - <input size="XX"> are too narrow after bug 362682

Status: VERIFIED FIXED

(Core :: Graphics, defect, P3)

Description

[Sylvain Pasche]

Attachment: screenshot

Regression range:

http://bonsai.mozilla.org/cvsquery.cgi?&date=explicit&mindate=2007-10-05%2022-26&maxdate=2007-10-06%2000-29

On the screenshot, top <input> is before, bottom one is after.

I saw the issue initially in the Firefox preferences > Advanced > Network > Cache: the textbox is too narrow.

Comment 3

[Boris Zbarsky [:bzbarsky]]

From bug 401555: this also bites the Preferences > Privacy the "remember visited pages for N days" textbox in Firefox.

Comment 4

[Stuart Parmenter]

Attachment: fix

Comment 5

[Reed Loden [:reed]]

Comment on attachment 286920 [details] [diff] [review]
fix

Could we possibly get this in for M9? It's a one line fix that makes a big difference in how number input boxes are rendered (as the problem is currently very noticeable on Linux).

Comment 6

[Boris Zbarsky [:bzbarsky]]

26.6?

Would be nice to have a name for the magic 64.0 too...

Comment 7

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 286920 [details] [diff] [review]
fix

a=drivers for M9

Comment 8

[Jeff Walden [:Waldo]]

Might the following setup work?  Big question is whether you can move the cursor like that -- I'm not sure if it's possible with unprivileged code, maybe even privileged code.  Also, I don't know what blur does to the positioning of the text displayed in the input.

Reference: page with a sized input
Test: same page, but move the cursor to the end of the textbox and blur it

Comment 9

[Boris Zbarsky [:bzbarsky]]

You can move a cursor in privileged code.  See for example <http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/content/html/content/test/test_bug300691-1.html&rev=1.1&mark=72-74#70>.  sendKey lives in <http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/testing/mochitest/tests/SimpleTest/EventUtils.js&rev=1.4#101>.

Comment 10

[Carsten Book [:Tomcat]]

verified fixed using the steps to reproduce (url) and Mozilla/5.0 (X11; U; Linux i686 (x86_64); en-US; rv:1.9b2) Gecko/2007121016 Firefox/3.0b2Mozilla/5.0 (X11; U; Linux i686 (x86_64); en-US; rv:1.9b2) Gecko/2007121016 Firefox/3.0b2 on Fedora F8 

-> Verified