399893 - Lightning 0.7 RC 1 on Mac: Address book icon exchanged

Status: VERIFIED FIXED

(Calendar :: Lightning Only, defect)

Description

[Thomas Stache]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; de; rv:1.8.1.7) Gecko/20070914 Firefox/2.0.0.7
Build Identifier: 0.7RC1 on Mac Thunderbird Version 2.0.0.6

With Lightning 0.7RC1 installed in Mac Thunderbird Version 2.0.0.6
(20070728) the address book icon is changed to the spell-check icon. I
confirmed that it reverts to the dictionary book, when Lightning is
disabled, and back to spell-check with Lightning enabled. I can also say
that it happens for both small and large icons, as well when dragged
into the customization palette.

Reproducible: Always

Comment 1

[Thomas Stache]

Attachment: screenshot of problem

Address book icon exchanged, rule in source list that shouldn't be there.

Comment 2

[Thomas Stache]

Attachment: reference screenshot

This is Thunderbird in Safe mode. Note that the icon reverts to the correct image, and the rule in the sidebar is gone.

Comment 3

[Berend Cornelius]

The rule to display the wrong icon can be found in the file "messengercompose.css" of the thunderbird project - whatever the reason might be:
#button-address {
  list-style-image: url("chrome://messenger/skin/messengercompose/compose-toolbar.png");
  -moz-image-region: rect(0px 48px 24px 24px) !important;
}

However this file is included by the today-pane (today-pane.xul) because of the rules .ab-closebutton... that are used by the today-pane's close-button. I suggest to just copy and rename these rules to the todaypane.css and delete the include of the messengercompose.css. According to Ulf this is not blocking.

Comment 4

[Berend Cornelius]

Attachment: patch that follows my proposal in comment #3

Comment 5

[Omar Bajraszewski]

Installing Noia 2.0 eXtreme 3.1 on Thunderbird 2.0.0.6 (windows XP) with lightning 0.7 causes the same effect. 

Comment 6

[Michael Büttner (no reviews TFN)]

Comment on attachment 285111 [details] [diff] [review]
patch that follows my proposal in comment #3

>+.today-closebutton {
>+  list-style-image: url("chrome://messenger/skin/icons/close-button.png");
>+  -moz-image-region: rect(0 16px 16px 0);
>+  -moz-appearance: none;
>+  border: none !important;
>+  padding: 2px;
>+}
You basically copied the css rules from mail/themes/pinstripe/.../messengercompose.css and mail/themes/qute/.../messengercompose.css and renamed these. Although, this is just fine, it shouldn't be the case that shared code/css/xul reaches out for the messenger chrome package (as it is the case here, as it currently is without this patch, as well). I think we should take this patch as it stands and probably consider moving the today pane to calendar/lightning in a spin-off bug. r=mickey.

Comment 7

[Thomas Stache]

Will the patch also cure the thin gray horizontal line in the sidebars, that shouldn't be there on Mac (it possibly is explicitely specified in the today pane chrome for the other platforms)?

Comment 8

[Stefan Sitter [:ssitter]]

(In reply to comment #3)
If this is really a bug in the Thunderbird I suggest to file a corresponding bug for Thunderbird too.

Comment 9

[Thomas Stache]

Huh? When errors appear after Lightning's styles are overlaid into Thunderbird, it's a Thunderbird error? I'd argue that the style rules for the Today Pane are not specific enough, and affect unintended areas of Thunderbird. 
OT: Really, I think Sun should sponsor a MacBook or something, so the devs have the possibility to test on that platform.

Comment 10

[Berend Cornelius]

patch checked in on trunk and MOZILLA_1_8_BRANCH. I also submitted bug 401306 for thunderbird.
Thomas, such things may very well happen. Although mickey is right when he said that it was quite risky to make use of a css rule of the messenger package it looks to me that I just revealed a thunderbird-bug that for some reasons has been hidden so far. Or do you have any reasonable explanation why a rule being used be the address-book button points to the spellcheck icon under MacOSX

Comment 11

[Berend Cornelius]

I submitted bug 401355 ([Today-pane]. Source code files should be shifted to calendar/lightning) to shift the today-pane-related files to calendar/lightning (see comment #6)

Comment 12

[allblue]

I can confirm that there is the problem described above in Lightning 0.7 with the icon of the address book with several themes.

Additionally I can confirm that the problem is fixed in this nightly 0.8pre:

ftp://ftp.mozilla.org/pub/mozilla.org/calendar/lightning/nightly/2007-10-27-03-mozilla1.8/windows-xpi/

Tested on TB 2.0.0.6 german WinXP.

Comment 13

[Martin Schröder [:mschroeder]]

Verified per comment#12.