399894 - crash at nsNavHistoryResult::BookmarkFolderObserversForId when setting nsINavHistoryQueryResultNode::containerOpen

Status: RESOLVED DUPLICATE of bug 387203

(Firefox :: Bookmarks & History, defect)

Description

[Myk Melez [:myk] [@mykmelez]]

When calling nsINavHistoryQueryResultNode::containerOpen for a variety of folders, the browser crashes at nsNavHistoryResult::BookmarkFolderObserversForId reporting EXC_BAD_ACCESS / KERN_PROTECTION_FAILURE:

http://crash-stats.mozilla.com/report/index/3d1635d4-7b5d-11dc-91e4-001a4bd43ef6?date=2007-10-15-20

The crash happens every time I call that method on those folders, and it crashes on the same folder every time.  I can provide a places.sqlite database if it would help diagnose and fix the problem.

Comment 1

[Dan Mills [:thunder]]

I couldn't reproduce this crash over the weekend, btw.  Though I can't say I tried super hard to get it.  Perhaps it's because you have an optimized build and I don't? (e.g. it could be a race condition)

Comment 2

[Dietrich Ayala (:dietrich)]

hey Myk, yes please either attach it or send it to me directly.

are you opening these folders via existing UI? if so, can you post the STR?

Comment 3

[(not reading, please use [e-mail] instead)]

this could be a duplicate of bug #387203.

myk, I have a patch for that bug, but it causes lots of leaks.

Comment 4

[(not reading, please use [e-mail] instead)]

myk, can you try out https://bugzilla.mozilla.org/attachment.cgi?id=284996 on the trunk and if that fixes it for you, I'd mark this bug a dup.

Comment 5

[Myk Melez [:myk] [@mykmelez]]

(In reply to comment #4)
> myk, can you try out https://bugzilla.mozilla.org/attachment.cgi?id=284996 on
> the trunk and if that fixes it for you, I'd mark this bug a dup.

Yup, that patch fixes the crash.  Marking as a dupe of bug 387203.

Comment 6

[Gervase Markham [:gerv]]

Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv