399930 - Optimize PlacesUtils getters

Status: RESOLVED FIXED

(Firefox :: Bookmarks & History, defect)

Description

[Asaf Romano (gone)]

Attachment: tentative patch

I would like to attempt reducing PlacesUtils performance overhead by addressing the issues raised in bug 385809 and bug 389368 (Hey Myk!).

Comment 1

[Mike Connor [:mconnor]]

Comment on attachment 285022 [details] [diff] [review]
tentative patch

looks good, let's get this on tinderbox while its quiet to see what it does

Comment 2

[Asaf Romano (gone)]

mozilla/browser/components/places/content/utils.js 1.72

Comment 3

[:Gavin Sharp [email: [e-mail]]]

Did this have any effect on performance metrics? If not, I think we should back it out (the removal of function names at least).

Comment 4

[Asaf Romano (gone)]

Both Ts and Txul were too noisy at the time of landing so dunno :( (I could claim 10ms Ts win and 10ms Txul hit...).

Having said that, these labels are not proven to be useful, esp. given the current state of Venkman.

Comment 5

[Dietrich Ayala (:dietrich)]

(In reply to comment #4)
> Both Ts and Txul were too noisy at the time of landing so dunno :( (I could
> claim 10ms Ts win and 10ms Txul hit...).
> 
> Having said that, these labels are not proven to be useful, esp. given the
> current state of Venkman.
> 

I'd prefer to have them. I've been using Venkman to profile bug 384370, and having "13ms anonymous" is not helpful at all.

Comment 6

[Dietrich Ayala (:dietrich)]

that said, if you test again, and there's a measurable perf improvement from removing them then i'll settle for "anonymous" ;)

Comment 7

[Asaf Romano (gone)]

backed-out due to tree state:
Checking in browser/components/places/content/utils.js;
/cvsroot/mozilla/browser/components/places/content/utils.js,v  <--  utils.js
new revision: 1.73; previous revision: 1.72
done

Comment 8

[Asaf Romano (gone)]

Attachment: v1.1

Don't remove function labels for now.

Checking in browser/components/places/content/utils.js;
/cvsroot/mozilla/browser/components/places/content/utils.js,v  <--  utils.js
new revision: 1.74; previous revision: 1.73
done

Comment 9

[Gervase Markham [:gerv]]

Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv