Free Gnomestripe

VERIFIED FIXED in Firefox 3 beta2

Status

()

Firefox
General
P2
normal
VERIFIED FIXED
11 years ago
9 years ago

People

(Reporter: rflint, Assigned: rflint)

Tracking

Trunk
Firefox 3 beta2
All
Linux
Points:
---
Dependency tree / graph
Bug Flags:
blocking-firefox3 +
in-testsuite -
in-litmus -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Current plans have us diverging enough from winstripe that the number of ifdefs and other hacks needed are just going to become unwieldy. We should make gnomestripe a proper top-level theme.
Flags: blocking-firefox3?
The drivers *adore* this bug title.
Flags: blocking-firefox3? → blocking-firefox3+
The sooner we get gnomestripe split out, the sooner we can start work ;)
Depends on: 400912
Ryan: ETA?
Target Milestone: Firefox 3 → Firefox 3 M10

Comment 4

11 years ago
Isn't this completed already? There were a number of checkins related to this bug earlier.
This is either a P1 or P2 IMO.

Comment 5

11 years ago
Oh, Ryan didn't copy the tab images so we must wait for bug 353785 for the theme to become good enough to use.
Tab images? Can't we just enable native GTK theming for tabs right away?

Comment 7

11 years ago
(In reply to comment #6)
> Tab images? Can't we just enable native GTK theming for tabs right away?
> 

Thats exactly why I mentioned bug 353785...
Sorry never mind, I understood you incorrectly. From what I'm reading though, the fix from 353785 could easily be added to the gnomestripe theme now?

Comment 9

11 years ago
(In reply to comment #8)
> Sorry never mind, I understood you incorrectly. From what I'm reading though,
> the fix from 353785 could easily be added to the gnomestripe theme now?

Ryan says he has a patch for it so we need to wait for him to attach it, then wait again for someone else to review the patch.
(In reply to comment #4)
> Isn't this completed already? There were a number of checkins related to this
> bug earlier.
Yep, other than the tab de-uglification and flipping build bits, gnomestripe is basically ready to go. I'm going to be AWOL for most of the morning, but I'll be wrapping this stuff up at some point this afternoon/evening.

Updated

11 years ago
Priority: -- → P2

Updated

11 years ago
Blocks: 401279
Created attachment 288792 [details] [diff] [review]
Flip the switch

Let's do this thing.
Attachment #288792 - Flags: review?(mconnor)

Comment 12

11 years ago
+ifneq (,$(filter gtk2,$(MOZ_WIDGET_TOOLKIT)))
+DIRS = gnomestripe

Are you sure this shouldn't be DIRS += gnomestripe like in toolkit?
(In reply to comment #12)
> +ifneq (,$(filter gtk2,$(MOZ_WIDGET_TOOLKIT)))
> +DIRS = gnomestripe
> 
> Are you sure this shouldn't be DIRS += gnomestripe like in toolkit?
> 

Nope, toolkit's winstripe + gnomestripe and DIRS isn't defined anywhere outside of that block on linux.
Plus, toolkit treats gnomestripe as an override theme to winstripe rather than a completely separate theme.

Comment 15

11 years ago
OK, but just as a suggestion, could this wait until the native icons in bug 381206 lands? If you do it will make the switch more exciting especially among the Linux-oriented press ;-)
(In reply to comment #15)
> OK, but just as a suggestion, could this wait until the native icons in bug
> 381206 lands? If you do it will make the switch more exciting especially among
> the Linux-oriented press ;-)
> 

Nope :)
We want perf numbers on tinderbox before landing that, but I'll be sure to get everything in before the nightly ;)
Comment on attachment 288792 [details] [diff] [review]
Flip the switch

free the, uh, foot?
Attachment #288792 - Flags: review?(mconnor) → review+
mozilla/browser/themes/Makefile.in                      1.3
mozilla/browser/themes/winstripe/browser/browser.css    1.133
mozilla/browser/themes/winstripe/browser/searchbar.css  1.22
Status: ASSIGNED → RESOLVED
Last Resolved: 11 years ago
Flags: in-testsuite-
Resolution: --- → FIXED

Updated

11 years ago
Depends on: 404069

Updated

11 years ago
Depends on: 403988
No longer depends on: 404069

Updated

11 years ago
Depends on: 404069
Depends on: 404167

Comment 19

11 years ago
Hi ryan, do you have a testcase for this bug so QA can verify this fix?
(In reply to comment #19)
> Hi ryan, do you have a testcase for this bug so QA can verify this fix?

Install Firefox on Linux. See theme?
Flags: in-litmus-

Comment 21

10 years ago
Verified fix on Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9pre) Gecko/2008050707 Minefield/3.0pre
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.