Closed Bug 399937 Opened 12 years ago Closed 12 years ago

Free Gnomestripe

Categories

(Firefox :: General, defect, P2)

All
Linux
defect

Tracking

()

VERIFIED FIXED
Firefox 3 beta2

People

(Reporter: rflint, Assigned: rflint)

References

Details

Attachments

(1 file)

Current plans have us diverging enough from winstripe that the number of ifdefs and other hacks needed are just going to become unwieldy. We should make gnomestripe a proper top-level theme.
Flags: blocking-firefox3?
The drivers *adore* this bug title.
Flags: blocking-firefox3? → blocking-firefox3+
The sooner we get gnomestripe split out, the sooner we can start work ;)
Ryan: ETA?
Target Milestone: Firefox 3 → Firefox 3 M10
Isn't this completed already? There were a number of checkins related to this bug earlier.
This is either a P1 or P2 IMO.
Oh, Ryan didn't copy the tab images so we must wait for bug 353785 for the theme to become good enough to use.
Tab images? Can't we just enable native GTK theming for tabs right away?
(In reply to comment #6)
> Tab images? Can't we just enable native GTK theming for tabs right away?
> 

Thats exactly why I mentioned bug 353785...
Sorry never mind, I understood you incorrectly. From what I'm reading though, the fix from 353785 could easily be added to the gnomestripe theme now?
(In reply to comment #8)
> Sorry never mind, I understood you incorrectly. From what I'm reading though,
> the fix from 353785 could easily be added to the gnomestripe theme now?

Ryan says he has a patch for it so we need to wait for him to attach it, then wait again for someone else to review the patch.
(In reply to comment #4)
> Isn't this completed already? There were a number of checkins related to this
> bug earlier.
Yep, other than the tab de-uglification and flipping build bits, gnomestripe is basically ready to go. I'm going to be AWOL for most of the morning, but I'll be wrapping this stuff up at some point this afternoon/evening.
Priority: -- → P2
Blocks: 401279
Attached patch Flip the switchSplinter Review
Let's do this thing.
Attachment #288792 - Flags: review?(mconnor)
+ifneq (,$(filter gtk2,$(MOZ_WIDGET_TOOLKIT)))
+DIRS = gnomestripe

Are you sure this shouldn't be DIRS += gnomestripe like in toolkit?
(In reply to comment #12)
> +ifneq (,$(filter gtk2,$(MOZ_WIDGET_TOOLKIT)))
> +DIRS = gnomestripe
> 
> Are you sure this shouldn't be DIRS += gnomestripe like in toolkit?
> 

Nope, toolkit's winstripe + gnomestripe and DIRS isn't defined anywhere outside of that block on linux.
Plus, toolkit treats gnomestripe as an override theme to winstripe rather than a completely separate theme.
OK, but just as a suggestion, could this wait until the native icons in bug 381206 lands? If you do it will make the switch more exciting especially among the Linux-oriented press ;-)
(In reply to comment #15)
> OK, but just as a suggestion, could this wait until the native icons in bug
> 381206 lands? If you do it will make the switch more exciting especially among
> the Linux-oriented press ;-)
> 

Nope :)
We want perf numbers on tinderbox before landing that, but I'll be sure to get everything in before the nightly ;)
Comment on attachment 288792 [details] [diff] [review]
Flip the switch

free the, uh, foot?
Attachment #288792 - Flags: review?(mconnor) → review+
mozilla/browser/themes/Makefile.in                      1.3
mozilla/browser/themes/winstripe/browser/browser.css    1.133
mozilla/browser/themes/winstripe/browser/searchbar.css  1.22
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Depends on: 404069
Depends on: 403988
No longer depends on: 404069
Depends on: 404069
Depends on: 404167
Hi ryan, do you have a testcase for this bug so QA can verify this fix?
(In reply to comment #19)
> Hi ryan, do you have a testcase for this bug so QA can verify this fix?

Install Firefox on Linux. See theme?
Flags: in-litmus-
Verified fix on Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9pre) Gecko/2008050707 Minefield/3.0pre
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.