Closed
Bug 399968
Opened 17 years ago
Closed 17 years ago
Possible regression introduced by attachment 197487 [details] [diff] [review] plus clean up of meaningless code
Categories
(Core :: Layout: Form Controls, defect)
Core
Layout: Form Controls
Tracking
()
RESOLVED
FIXED
People
(Reporter: neil, Assigned: neil)
References
Details
(Keywords: regression)
Attachments
(1 file)
|
1.31 KB,
patch
|
roc
:
review+
roc
:
superreview+
roc
:
approval1.9+
|
Details | Diff | Splinter Review |
The patch for bug 258875 contains 3 meaningless lines of code, plus a possible regression due to the change of a style rule:
>+ textControl->SetDisabled(PR_TRUE);
This doesn't work (it is actually kept in sync with the input type="file" itself). Fortunately this makes click-to-open-filepicker work!
>-input[type="file"] > input[type="text"] {
>+input[type="file"] > input[type="text"][disabled] {
The input type="text" isn't actually disabled in the typical case...
>+ -moz-user-focus: ignore !important;
This no longer has any meaning for HTML form elements.
>+ -moz-user-input: enabled;
This style rule has no effect (the only effect it could have is to override some other style rule but HTML form elements should not be disabled via style).
Flags: blocking1.9?
|
Assignee | |
Comment 1•17 years ago
|
||
Assignee: nobody → neil
Status: NEW → ASSIGNED
Attachment #285067 -
Flags: superreview?(roc)
Attachment #285067 -
Flags: review?(roc)
Attachment #285067 -
Flags: superreview?(roc)
Attachment #285067 -
Flags: superreview+
Attachment #285067 -
Flags: review?(roc)
Attachment #285067 -
Flags: review+
Attachment #285067 -
Flags: approval1.9+
|
|
Assignee | |
Comment 2•17 years ago
|
||
Fix checked in.
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•