400081 - Leak gfxFont and gfxTextRun with font-size: 0

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[Jesse Ruderman]

Attachment: testcase

Steps to reproduce:
1. export XPCOM_MEM_LEAK_LOG=2
2. Run Firefox.
3. Load the testcase.
4. Quit.

Result: trace-refcnt reports that instances of the following classes leaked:
  gfxFont, gfxTextRun, gfxTextRunFactory, nsStringBuffer, nsTArray_base

I think this is a regression from within the last week.

Comment 1

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Chris, this sounds like you

Comment 2

[Chris Pearce [:cpearce (Not reading bugmail)]]

Yup, this was me, removing my patch made the leak go away. Taking bug.

Comment 3

[Chris Pearce [:cpearce (Not reading bugmail)]]

Attachment: Patch v1 - added a gfxTextRun release

Added a textrun release on a control path that must have not be being hit before.

Comment 4

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 285273 [details] [diff] [review]
Patch v1 - added a gfxTextRun release

rerequest approval when we get out of tree-red state

Comment 5

[Reed Loden [:reed]]

Checking in layout/generic/nsTextFrameThebes.cpp;
/cvsroot/mozilla/layout/generic/nsTextFrameThebes.cpp,v  <--  nsTextFrameThebes.cpp
new revision: 3.127; previous revision: 3.126
done

Comment 6

[Jesse Ruderman]

Reftest checked in.