400094 - JSS should link conditionally with libnssutil

Status: RESOLVED FIXED

(JSS Graveyard :: Library, defect, P1)

Description

[Julien Pierre]

The JSS trunk is currently broken when compiled against coreconf and NSS from NSS_3_11_BRANCH, because it tries to look for libnssutil which is new in NSS 3.12 . The JSS Makefile needs to be changed to link with this new library conditionally, only when JSS is being built against NSS 3.12 or newer.

Comment 1

[Christophe Ravel]

Attachment: conditionally add libnssutil3

I had to cleanup the makefile a bit to avoid the duplication of the list of libraries needed (Windows and non-Windows).

1- list the libraries for NSPR and NSS (with conditional add of nssutil3)
2- add the appropriate prefix and suffix for the link:

  on Windows: $(NSS_LIB_DIR)/[lib].lib
    prefix= $(NSS_LIB_DIR)/
    suffix= .$(LIB_SUFFIX) [defined in coreconf/WIN32.mk:LIB_SUFFIX = lib]

  on non-Windows: -l[lib]
    prefix= -l

Build tested on Solaris and Windows.

Comment 2

[Christophe Ravel]

Note: target is currently because of the lack of 4.2.6. The real target is 4.2.6.

Comment 3

[Christophe Ravel]

Fix committed to the trunk.
r=glen.beasley

Checking in coreconf/config.mk;
/cvsroot/mozilla/security/coreconf/config.mk,v  <--  config.mk
new revision: 1.22; previous revision: 1.21
done
Checking in jss/lib/config.mk;
/cvsroot/mozilla/security/jss/lib/config.mk,v  <--  config.mk
new revision: 1.24; previous revision: 1.23
done

Comment 4

[Christophe Ravel]

Changing target milestone to 4.2.6 now that it exists.