400096 - In <pippki.properties> (at least), rename "Web Site" to "Server"

Status: VERIFIED FIXED

(Core Graveyard :: Security: UI, defect)

Description

[Serge Gautherie (:sgautherie)]

[Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9a9pre) Gecko/2007101611 SeaMonkey/2.0a1pre] (nightly) (W2Ksp4)

(Found while testing bug 399043.)

Bug 387480 attachment 283376 [details] [diff] [review] renamed the tab to "Servers";
but its buttons are still using "Web Site":
'Import...' and 'Delete...' for example.

Check <http://mxr.mozilla.org/seamonkey/search?string=web+site&find=%2Fsecurity%2F&findi=&filter=&tree=seamonkey>
especially <pippki.properties>.

Comment 1

[Kai Engert (:KaiE:)]

Serge, I'm not sure which UI you are referring to.

Cert Manager? All buttons only have the verb, but not the subject.
I do not see buttons that say "Web Site".

Can you please describe where you see it?

Comment 2

[Kai Engert (:KaiE:)]

Oh, you mean the "please confirm" messages when deleting an exception!
That's indeed a good point.

Patch coming up

Comment 3

[Kai Engert (:KaiE:)]

Attachment: Patch v1 [Checkin: Comment 7]

Comment 4

[Johnathan Nightingale [:johnath]]

Comment on attachment 285752 [details] [diff] [review]
Patch v1
[Checkin: Comment 7]

looks good to me - search and replace ftw!  None of these keys seem to be used elsewhere, so r=me

Comment 5

[Kai Engert (:KaiE:)]

Comment on attachment 285752 [details] [diff] [review]
Patch v1
[Checkin: Comment 7]

I think Johnathan's review should be sufficient for this wording-only change (and string ID update).

Requesting approval.

Comment 6

[Serge Gautherie (:sgautherie)]

(In reply to comment #1)
> Can you please describe where you see it?

(In reply to comment #2)
> Oh, you mean the "please confirm" messages when deleting an exception!

Yes, look at the dialogs after using the buttons.

(In reply to comment #3)
> Created an attachment (id=285752) [details]

This patch misses to update
"importWebSiteCertPrompt=Select File containing Web Site certificate to import"
? (and maybe others ?)

Comment 7

[Kai Engert (:KaiE:)]

checked in

Comment 8

[Serge Gautherie (:sgautherie)]

Kai, what about comment 6 ?

Comment 9

[Kai Engert (:KaiE:)]

Sorry I missed that when I checked in the reviewed and approved patch.
Reopening so we can address the remaining strings.

I agree we should fix that, too.
Feel free to provide a patch.

Comment 10

[Serge Gautherie (:sgautherie)]

Attachment: (Bv1) |importWebSiteCertPrompt| fix

Used at 1 place only:
<http://mxr.mozilla.org/seamonkey/search?string=importWebSiteCertPrompt&case=on&tree=seamonkey>

Comment 11

[Kai Engert (:KaiE:)]

Comment on attachment 288011 [details] [diff] [review]
(Bv1) |importWebSiteCertPrompt| fix

Can you please change the string ID, at both places (properties and xul)?

Comment 12

[Serge Gautherie (:sgautherie)]

Attachment: (Bv1a) |importWebSiteCertPrompt| fix

Bv1, with comment 11 update.

New name available:
<http://mxr.mozilla.org/seamonkey/search?string=importServerCertPrompt&case=on&tree=seamonkey>

Comment 13

[Robert Kaiser]

Comment on attachment 285752 [details] [diff] [review]
Patch v1
[Checkin: Comment 7]

>+deleteSslCertImpact3=If you delete a server exception, you restore the usual security checks for that site and require it uses a valid certificate.

Oops. There is still a "site" in that string.

Maybe this can be fixed without an ID change...

Comment 14

[Serge Gautherie (:sgautherie)]

Attachment: (Bv2a) |importWebSiteCertPrompt| fix (++) [Checkin: Comment 16]

Bv1a, with comment 13 update.

Comment 15

[Kai Engert (:KaiE:)]

Comment on attachment 290405 [details] [diff] [review]
(Bv2a) |importWebSiteCertPrompt| fix (++)
[Checkin: Comment 16]

r=kengert

Comment 16

[Reed Loden [:reed]]

Checking in security/manager/locales/en-US/chrome/pippki/pippki.properties;
/cvsroot/mozilla/security/manager/locales/en-US/chrome/pippki/pippki.properties,v  <--  pippki.properties
new revision: 1.17; previous revision: 1.16
done
Checking in security/manager/pki/resources/content/certManager.js;
/cvsroot/mozilla/security/manager/pki/resources/content/certManager.js,v  <--  certManager.js
new revision: 1.53; previous revision: 1.52
done

Comment 17

[Serge Gautherie (:sgautherie)]

[Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9b2pre) Gecko/2007120103 SeaMonkey/2.0a1pre] (nightly) (W2Ksp4)

V.Fixed.