In <pippki.properties> (at least), rename "Web Site" to "Server"

VERIFIED FIXED in mozilla1.9beta2

Status

Core Graveyard
Security: UI
--
trivial
VERIFIED FIXED
11 years ago
2 years ago

People

(Reporter: sgautherie, Assigned: kaie)

Tracking

Trunk
mozilla1.9beta2

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments, 2 obsolete attachments)

(Reporter)

Description

11 years ago
[Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9a9pre) Gecko/2007101611 SeaMonkey/2.0a1pre] (nightly) (W2Ksp4)

(Found while testing bug 399043.)

Bug 387480 attachment 283376 [details] [diff] [review] renamed the tab to "Servers";
but its buttons are still using "Web Site":
'Import...' and 'Delete...' for example.

Check <http://mxr.mozilla.org/seamonkey/search?string=web+site&find=%2Fsecurity%2F&findi=&filter=&tree=seamonkey>
especially <pippki.properties>.
(Assignee)

Comment 1

11 years ago
Serge, I'm not sure which UI you are referring to.

Cert Manager? All buttons only have the verb, but not the subject.
I do not see buttons that say "Web Site".

Can you please describe where you see it?
(Assignee)

Comment 2

11 years ago
Oh, you mean the "please confirm" messages when deleting an exception!
That's indeed a good point.

Patch coming up
(Assignee)

Comment 3

11 years ago
Created attachment 285752 [details] [diff] [review]
Patch v1
[Checkin: Comment 7]
Attachment #285752 - Flags: review?(johnath)
Comment on attachment 285752 [details] [diff] [review]
Patch v1
[Checkin: Comment 7]

looks good to me - search and replace ftw!  None of these keys seem to be used elsewhere, so r=me
Attachment #285752 - Flags: review?(johnath) → review+
(Assignee)

Comment 5

11 years ago
Comment on attachment 285752 [details] [diff] [review]
Patch v1
[Checkin: Comment 7]

I think Johnathan's review should be sufficient for this wording-only change (and string ID update).

Requesting approval.
Attachment #285752 - Flags: approval1.9?
(Reporter)

Comment 6

11 years ago
(In reply to comment #1)
> Can you please describe where you see it?

(In reply to comment #2)
> Oh, you mean the "please confirm" messages when deleting an exception!

Yes, look at the dialogs after using the buttons.

(In reply to comment #3)
> Created an attachment (id=285752) [details]

This patch misses to update
"importWebSiteCertPrompt=Select File containing Web Site certificate to import"
? (and maybe others ?)

Updated

11 years ago
Attachment #285752 - Flags: approval1.9? → approval1.9+
(Assignee)

Comment 7

11 years ago
checked in
Status: NEW → RESOLVED
Last Resolved: 11 years ago
Resolution: --- → FIXED
(Reporter)

Comment 8

11 years ago
Kai, what about comment 6 ?
(Assignee)

Comment 9

11 years ago
Sorry I missed that when I checked in the reviewed and approved patch.
Reopening so we can address the remaining strings.

I agree we should fix that, too.
Feel free to provide a patch.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
(Reporter)

Updated

11 years ago
OS: Windows 2000 → All
Hardware: PC → All
(Reporter)

Comment 10

11 years ago
Created attachment 288011 [details] [diff] [review]
(Bv1) |importWebSiteCertPrompt| fix

Used at 1 place only:
<http://mxr.mozilla.org/seamonkey/search?string=importWebSiteCertPrompt&case=on&tree=seamonkey>
Attachment #288011 - Flags: review?(kengert)
(Assignee)

Comment 11

11 years ago
Comment on attachment 288011 [details] [diff] [review]
(Bv1) |importWebSiteCertPrompt| fix

Can you please change the string ID, at both places (properties and xul)?
Attachment #288011 - Flags: review?(kengert) → review-
(Reporter)

Updated

11 years ago
Attachment #288011 - Attachment description: |importWebSiteCertPrompt| fix → (Bv1) |importWebSiteCertPrompt| fix
(Reporter)

Comment 12

11 years ago
Created attachment 288013 [details] [diff] [review]
(Bv1a) |importWebSiteCertPrompt| fix

Bv1, with comment 11 update.

New name available:
<http://mxr.mozilla.org/seamonkey/search?string=importServerCertPrompt&case=on&tree=seamonkey>
Attachment #288013 - Flags: review?(kengert)
(Reporter)

Updated

11 years ago
Attachment #288011 - Attachment is obsolete: true

Comment 13

11 years ago
Comment on attachment 285752 [details] [diff] [review]
Patch v1
[Checkin: Comment 7]

>+deleteSslCertImpact3=If you delete a server exception, you restore the usual security checks for that site and require it uses a valid certificate.

Oops. There is still a "site" in that string.

Maybe this can be fixed without an ID change...
(Reporter)

Comment 14

11 years ago
Created attachment 290405 [details] [diff] [review]
(Bv2a) |importWebSiteCertPrompt| fix (++)
[Checkin: Comment 16]

Bv1a, with comment 13 update.
Attachment #288013 - Attachment is obsolete: true
Attachment #290405 - Flags: review?(kengert)
Attachment #288013 - Flags: review?(kengert)
(Assignee)

Comment 15

11 years ago
Comment on attachment 290405 [details] [diff] [review]
(Bv2a) |importWebSiteCertPrompt| fix (++)
[Checkin: Comment 16]

r=kengert
Attachment #290405 - Flags: review?(kengert) → review+
Attachment #290405 - Flags: approval1.9?
(Reporter)

Updated

11 years ago
Attachment #285752 - Attachment description: Patch v1 → Patch v1 [Checkin: Comment 7]

Updated

11 years ago
Attachment #290405 - Flags: approval1.9? → approval1.9+
Keywords: checkin-needed
Checking in security/manager/locales/en-US/chrome/pippki/pippki.properties;
/cvsroot/mozilla/security/manager/locales/en-US/chrome/pippki/pippki.properties,v  <--  pippki.properties
new revision: 1.17; previous revision: 1.16
done
Checking in security/manager/pki/resources/content/certManager.js;
/cvsroot/mozilla/security/manager/pki/resources/content/certManager.js,v  <--  certManager.js
new revision: 1.53; previous revision: 1.52
done
Status: REOPENED → RESOLVED
Last Resolved: 11 years ago11 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9 M10
(Reporter)

Updated

11 years ago
Attachment #290405 - Attachment description: (Bv2a) |importWebSiteCertPrompt| fix (++) → (Bv2a) |importWebSiteCertPrompt| fix (++) [Checkin: Comment 16]
(Reporter)

Comment 17

11 years ago
[Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9b2pre) Gecko/2007120103 SeaMonkey/2.0a1pre] (nightly) (W2Ksp4)

V.Fixed.
Status: RESOLVED → VERIFIED
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.