cert exception file has unix line endings on Windows

RESOLVED FIXED

Status

()

Core
Security: PSM
P2
normal
RESOLVED FIXED
10 years ago
10 years ago

People

(Reporter: Nelson Bolyard (seldom reads bugmail), Assigned: kaie)

Tracking

(Blocks: 1 bug)

Trunk
x86
Windows XP
Points:
---
Bug Flags:
blocking1.9 +

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [has-patch])

Attachments

(1 attachment)

1.42 KB, patch
Nelson Bolyard (seldom reads bugmail)
: review+
Robert Sayre
: approval1.9+
Details | Diff | Splinter Review
The new file of bad cert exceptions is a text file.
It is written with Unix line endings on all platforms, including Windows.
This means it cannot be cleanly displayed or edited on Windows.
All text files should have platform-dependent line endings.
Flags: blocking1.9?
(Assignee)

Comment 1

10 years ago
Created attachment 285443 [details] [diff] [review]
Patch v1
Attachment #285443 - Flags: review?(nelson)
(Reporter)

Comment 2

10 years ago
Comment on attachment 285443 [details] [diff] [review]
Patch v1

This will write them correctly.  Will they be read correctly?
Attachment #285443 - Flags: review?(nelson) → review+
(Assignee)

Comment 3

10 years ago
(In reply to comment #2)
> (From update of attachment 285443 [details] [diff] [review])
> This will write them correctly.  Will they be read correctly?

Yes, tested.
(Assignee)

Updated

10 years ago
Attachment #285443 - Flags: approval1.9?
If the file can be stored with different endings then the reading code needs to be able to handle any platform's variant at any time.

 - people copy profiles to new architectures
   (especially with the rising popularity of multi-OS machines)

 - people share the same profile directory on different OS's.
   Again, increasingly true with multi-boot and VM-based multi-OS
   machines, though from the earliest days Netscape had to worry 
   about network-mounted profiles shared amongst machines with
   differing endianness.

Comment 5

10 years ago
Comment on attachment 285443 [details] [diff] [review]
Patch v1

Please answer dveditz's questions before requesting approval.
Attachment #285443 - Flags: approval1.9? → approval1.9-
(Assignee)

Comment 6

10 years ago
I think I answered in comment 3 that I tested that files will always be read correctly, independently of the line endings.

The backend code that reads lines in (somewhere in a global stream class) seemed to allow for any combinations of line endings.

I explicitly tested:
- produce file on Linux
- copy file to Windows 
- run on Windows
=> works
(Reporter)

Comment 7

10 years ago
Comment on attachment 285443 [details] [diff] [review]
Patch v1

Kai answered the questions
Attachment #285443 - Flags: approval1.9- → approval1.9?

Comment 8

10 years ago
Comment on attachment 285443 [details] [diff] [review]
Patch v1

OK, I understand this bug better now. Thanks Kaie and Nelson.
Attachment #285443 - Flags: approval1.9? → approval1.9+

Updated

10 years ago
Flags: blocking1.9? → blocking1.9+

Updated

10 years ago
Priority: -- → P2

Updated

10 years ago
Whiteboard: [has-patch]
(Assignee)

Comment 9

10 years ago
checked in, fixed.
Status: NEW → RESOLVED
Last Resolved: 10 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.