400198 - blocklist.xml file has Unix line endings on Windows

Status: RESOLVED WONTFIX

(Firefox :: General, defect)

Description

[Nelson Bolyard (seldom reads bugmail)]

xml files are text files.  They should have platform-dependent line endings.
The file blocklist.xml is written with Unix style line endings on Windows.
This means it cannot be properly displayed or edited with platform native
text tools on Windows.

Comment 1

[:Gavin Sharp [email: [e-mail]]]

This file is retrieved from the Web and then serialized to disk by the blocklist service. It's not meant to be edited manually, and I don't think added code needed to write it with platform-native line endings is worth the cost, especially since it only benefits people that a) want to edit it manually and b) don't have a text editor that can handle UNIX line endings. I think that set of people is incredibly small.

Comment 2

[Nelson Bolyard (seldom reads bugmail)]

Many text editors on Windows will convert a file to Windows line endings
before writing it out.  If the resulting file still works in the mozilla
product, that's acceptable.  Otherwise...

Comment 3

[:Gavin Sharp [email: [e-mail]]]

Worrying about people who manually edit files that weren't meant to be hand-edited isn't very high on my list of things to worry about either, to be honest... though I suspect that the code that parses the file should deal fine, without having verified.

Comment 4

[Mark Banner (:standard8)]

If there was an issue here, we'd have spotted it years ago. Not sure if we still do this, but it isn't intended for user-editing, so I think this is wontfix.