400243 - "votes:n" quicksearch should be "at least n votes", not "more than n votes"

Status: RESOLVED FIXED

(Bugzilla :: Query/Bug List, defect)

Description

[Jesse Ruderman]

A search with "votes:2" should find bugs with 2 or more votes.  It currently finds bugs with 3 or more votes.

Comment 1

[Frédéric Buclin]

This is a minor regression due to bug 70907. The JS had:

add_chart("votes","greaterthan",String(n-1));

but now Quicksearch.pm uses:

addChart('votes', 'greaterthan', $1, $negate);

Looks like a one-liner to fix.

Comment 2

[Frédéric Buclin]

Attachment: patch, v1

Comment 3

[Frédéric Buclin]

Marc, why do we pass $negate to addChart() for votes as negateComparisonType() at lines 507/485 of Quicksearch.pm says that "greaterthan" is not valid with negation?

Comment 4

[Frédéric Buclin]

Attachment: patch including documentation, v1

votes:N, votes>=N and votes>N are mentioned nowhere in the documentation about QS. This patch adds them. I also removed obsolete examples from the doc as well.

Comment 5

[Frédéric Buclin]

tip:

Checking in Bugzilla/Search/Quicksearch.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/Search/Quicksearch.pm,v  <--  Quicksearch.pm
new revision: 1.19; previous revision: 1.18
done
Checking in template/en/default/pages/quicksearchhack.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/pages/quicksearchhack.html.tmpl,v  <--  quicksearchhack.html.tmpl
new revision: 1.7; previous revision: 1.6
done


3.0.2:

Checking in Bugzilla/Search/Quicksearch.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/Search/Quicksearch.pm,v  <--  Quicksearch.pm
new revision: 1.12.2.3; previous revision: 1.12.2.2
done
Checking in template/en/default/pages/quicksearchhack.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/pages/quicksearchhack.html.tmpl,v  <--  quicksearchhack.html.tmpl
new revision: 1.3.2.1; previous revision: 1.3
done