400324 - Remove old safebrowsing "speech bubble" UI code

Status: RESOLVED FIXED

(Toolkit :: Safe Browsing, defect, P2)

Description

[Johnathan Nightingale [:johnath]]

When bug 399233 lands, phishing sites, like malware, will be handled with an error page instead of the Firefox 2 "speech bubble" UI.  This UI should be removed since:

 - it is no longer used
 - it is broken anyhow in its current form (bug 341950)
 - being an overlay to browser.xul, there is almost certainly a perf hit to having it stick around.

Note that most of safebrowsing should stay, like the warden code that handles detection and updates - just the UI needs to be excised.

Comment 1

[Ryan Flint [:rflint] (ping via IRC for reviews)]

Attachment: Patch

Despite the scary size, this mostly just file removals. The interesting changes are to sb-loader.js to change the way the report menuitem (I'll fix the report error menuitem in bug 415846) is updated so that nsIDocNavStartProgressListener can finally be removed and to move most of the init/shutdown logic to application.js so that we're not tearing down and setting up pref observers and attempting to register blacklists every time a new window is opened.

Comment 2

[Tony Chang (Google)]

Comment on attachment 305486 [details] [diff] [review]
Patch

Can we get rid of the phishing-afterload-warning-message.dtd file too?

This patch looks good to me as long as there are no memory leaks on shutdown.

Comment 3

[Ryan Flint [:rflint] (ping via IRC for reviews)]

Comment on attachment 305486 [details] [diff] [review]
Patch

We're currently using a couple strings from it for the docshell block page and report error menuitem - I'll file a followup for the strings we're not using.

Comment 4

[Damon Sicore (:damons)]

Comment on attachment 305486 [details] [diff] [review]
Patch

a1.9+=damons