Alias Ci.nsIDownloadManager to nsIDM, clean spaces, fix headings

VERIFIED FIXED in mozilla1.9beta2

Status

()

Toolkit
Downloads API
VERIFIED FIXED
10 years ago
9 years ago

People

(Reporter: Mardak, Assigned: Mardak)

Tracking

Trunk
mozilla1.9beta2
Points:
---
Bug Flags:
in-testsuite -
in-litmus -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

10 years ago
Ci.nsIDownloadManager is really long..
(Assignee)

Comment 1

10 years ago
Created attachment 285669 [details] [diff] [review]
v1

convert to nsIDM
:%s/Ci\.nsIDownloadManager/nsIDM/g

remove trailing spaces
:%s/ \+$

convert 79 slashes to 80
:%s/^\(\/\{79\}\)$/\1\/

convert headings with 2 slash to 4 slash
:%s/^\(\/\{80\}\n\/\/\) /\1\/\/

+const nsIDM = Ci.nsIDownloadManager;
+let gDownloadManager = Cc["@mozilla.org/download-manager;1"].getService(nsIDM);
Assignee: nobody → edilee
Status: NEW → ASSIGNED
Attachment #285669 - Flags: review?(comrade693+bmo)
(Assignee)

Updated

10 years ago
Blocks: 223895
Comment on attachment 285669 [details] [diff] [review]
v1

r=sdwilsh

goodbye blame, but this is nice to get done.
Attachment #285669 - Flags: review?(comrade693+bmo) → review+
(Assignee)

Comment 3

10 years ago
Comment on attachment 285669 [details] [diff] [review]
v1

This would be needed for showing eTLD for done downloads which could land after the revised eTLD service lands for M9.
Attachment #285669 - Flags: approvalM9?
Comment on attachment 285669 [details] [diff] [review]
v1

defer for now, if we get to a decision point real soon on what UI changes to make for M9 we may reconsider this.
Attachment #285669 - Flags: approvalM9?
Attachment #285669 - Flags: approvalM9-
Attachment #285669 - Flags: approval1.9+
(Assignee)

Comment 5

10 years ago
Checking in toolkit/mozapps/downloads/content/DownloadProgressListener.js;
/cvsroot/mozilla/toolkit/mozapps/downloads/content/DownloadProgressListener.js,v  <--  DownloadProgressListener.js
new revision: 1.28; previous revision: 1.27
done
Checking in toolkit/mozapps/downloads/content/downloads.js;
/cvsroot/mozilla/toolkit/mozapps/downloads/content/downloads.js,v  <--  downloads.js
new revision: 1.98; previous revision: 1.97
done
Status: ASSIGNED → RESOLVED
Last Resolved: 10 years ago
Flags: in-testsuite-
Flags: in-litmus-
Resolution: --- → FIXED
Target Milestone: --- → Firefox 3 M10
Verified FIXED using LXR:

http://bonsai.mozilla.org/cvsview2.cgi?diff_mode=context&whitespace_mode=show&file=DownloadProgressListener.js&branch=&root=/cvsroot&subdir=mozilla/toolkit/mozapps/downloads/content&command=DIFF_FRAMESET&rev1=1.27&rev2=1.28

http://bonsai.mozilla.org/cvsview2.cgi?diff_mode=context&whitespace_mode=show&file=downloads.js&branch=&root=/cvsroot&subdir=mozilla/toolkit/mozapps/downloads/content&command=DIFF_FRAMESET&rev1=1.97&rev2=1.98

Status: RESOLVED → VERIFIED
Product: Firefox → Toolkit
You need to log in before you can comment on or make changes to this bug.