400616 - Alias Ci.nsIDownloadManager to nsIDM, clean spaces, fix headings

Status: VERIFIED FIXED

(Toolkit :: Downloads API, defect)

Description

[Ed Lee :Mardak]

Ci.nsIDownloadManager is really long..

Comment 1

[Ed Lee :Mardak]

Attachment: v1

convert to nsIDM
:%s/Ci\.nsIDownloadManager/nsIDM/g

remove trailing spaces
:%s/ \+$

convert 79 slashes to 80
:%s/^\(\/\{79\}\)$/\1\/

convert headings with 2 slash to 4 slash
:%s/^\(\/\{80\}\n\/\/\) /\1\/\/

+const nsIDM = Ci.nsIDownloadManager;
+let gDownloadManager = Cc["@mozilla.org/download-manager;1"].getService(nsIDM);

Comment 2

[Shawn Wilsher :sdwilsh]

Comment on attachment 285669 [details] [diff] [review]
v1

r=sdwilsh

goodbye blame, but this is nice to get done.

Comment 3

[Ed Lee :Mardak]

Comment on attachment 285669 [details] [diff] [review]
v1

This would be needed for showing eTLD for done downloads which could land after the revised eTLD service lands for M9.

Comment 4

[Mike Connor [:mconnor]]

Comment on attachment 285669 [details] [diff] [review]
v1

defer for now, if we get to a decision point real soon on what UI changes to make for M9 we may reconsider this.

Comment 5

[Ed Lee :Mardak]

Checking in toolkit/mozapps/downloads/content/DownloadProgressListener.js;
/cvsroot/mozilla/toolkit/mozapps/downloads/content/DownloadProgressListener.js,v  <--  DownloadProgressListener.js
new revision: 1.28; previous revision: 1.27
done
Checking in toolkit/mozapps/downloads/content/downloads.js;
/cvsroot/mozilla/toolkit/mozapps/downloads/content/downloads.js,v  <--  downloads.js
new revision: 1.98; previous revision: 1.97
done

Comment 6

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED using LXR:

http://bonsai.mozilla.org/cvsview2.cgi?diff_mode=context&whitespace_mode=show&file=DownloadProgressListener.js&branch=&root=/cvsroot&subdir=mozilla/toolkit/mozapps/downloads/content&command=DIFF_FRAMESET&rev1=1.27&rev2=1.28

http://bonsai.mozilla.org/cvsview2.cgi?diff_mode=context&whitespace_mode=show&file=downloads.js&branch=&root=/cvsroot&subdir=mozilla/toolkit/mozapps/downloads/content&command=DIFF_FRAMESET&rev1=1.97&rev2=1.98