400617 - Include eTLD + 1 for failed, canceled, blocked downloads

Status: VERIFIED FIXED

(Toolkit :: Downloads API, defect)

Description

[Ed Lee :Mardak]

Per design from bug 397655.

Canceled -- etld
Failed -- etld
Blocked -- etld

(Well.. not sure about the blocked string..)

Comment 1

[Ed Lee :Mardak]

Attachment: v1

Add more to the stateSize hash of function using inline "lambda" functions.

Comment 2

[Shawn Wilsher :sdwilsh]

Comment on attachment 285673 [details] [diff] [review]
v1

>+stateFailed=Failed
>+stateCanceled=Canceled
>+stateBlocked=Blocked
Let's keep it as "Blocked by Parental Controls".  There's a bug to make the string more unique, but I think the UX team said we should have separate strings, so that bug is gonna get morphed (next on todo list).

r=sdwilsh

Comment 3

[Ed Lee :Mardak]

Attachment: v1.1

(In reply to comment #2)
> >+stateBlocked=Blocked
> Let's keep it as "Blocked by Parental Controls"
Done and restored the comment as a LOCALIZATION NOTE.

Probably wont be aM9 unless the blocking bug also gets aM9+.

Comment 4

[Ed Lee :Mardak]

a? This can land with bug 223895 (which is a+ b-ff3+).

Comment 5

[Shawn Wilsher :sdwilsh]

Let's land them separately.

Comment 6

[Ed Lee :Mardak]

Checking in toolkit/locales/en-US/chrome/mozapps/downloads/downloads.dtd;
/cvsroot/mozilla/toolkit/locales/en-US/chrome/mozapps/downloads/downloads.dtd,v  <--  downloads.dtd
new revision: 1.15; previous revision: 1.14
done
Checking in toolkit/locales/en-US/chrome/mozapps/downloads/downloads.properties;
/cvsroot/mozilla/toolkit/locales/en-US/chrome/mozapps/downloads/downloads.properties,v  <--  downloads.properties
new revision: 1.12; previous revision: 1.11
done
Checking in toolkit/mozapps/downloads/content/download.xml;
/cvsroot/mozilla/toolkit/mozapps/downloads/content/download.xml,v  <--  download.xml
new revision: 1.39; previous revision: 1.38
done
Checking in toolkit/mozapps/downloads/content/downloads.js;
/cvsroot/mozilla/toolkit/mozapps/downloads/content/downloads.js,v  <--  downloads.js
new revision: 1.100; previous revision: 1.99
done

Comment 7

[Shaohua Wen]

Hi There,
  What does the "Parental Controls" means here?
  Does it equals to the "Parental Controls" function in Vista?

Comment 8

[:Gavin Sharp [email: [e-mail]]]

(In reply to comment #7)
> Hi There,
>   What does the "Parental Controls" means here?
>   Does it equals to the "Parental Controls" function in Vista?

Yes, exactly. Maybe it would be a good idea to file a bug to add a l10n note.

Comment 9

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED, now that the Parental Controls patch has landed.

Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9pre) Gecko/2008041306 Minefield/3.0pre

and

Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9pre) Gecko/2008041304 Minefield/3.0pre