400621 - Linux crashreporter client has additional system-header dependencies

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Manish Singh]

Attachment: Add some more gtk headers

This fixes a build failure I get with gcc 4.2.

Comment 1

[Benjamin Smedberg]

Comment on attachment 285676 [details] [diff] [review]
Add some more gtk headers

Ted, are we including all these files explicitly? Is there a meta-header we could use instead (gtk/gtk.h), to avoid having to make this list larger and larget and less manageable?

Comment 2

[Reed Loden [:reed]]

(In reply to comment #1)
> (From update of attachment 285676 [details] [diff] [review])
> Ted, are we including all these files explicitly? Is there a meta-header we
> could use instead (gtk/gtk.h), to avoid having to make this list larger and
> larget and less manageable?

gtk/gtk.h is already in the list.

Comment 3

[(not currently active) Ted Mielczarek]

We are, in fact, and they've been in there for quite some time:
http://bonsai.mozilla.org/cvsblame.cgi?file=/mozilla/toolkit/crashreporter/client
/crashreporter_linux.cpp&rev=1.9&mark=53-68#53

I don't really know anything about GTK, so I can't comment as to whether we could just include one meta-header.

Comment 4

[Manish Singh]

You can certainly just include <gtk/gtk.h> instead of all the files individually. I don't see a rationale for not doing that.

As for them being in there for a while, this worked fine with gcc 4.1, but with gcc 4.2 the build failed due to missing symbols.

Comment 5

[(not currently active) Ted Mielczarek]

Would you care to provide a patch to replace all those includes with that one include?  I don't have gcc 4.2 here, so I can't verify that it works properly.

Comment 6

[Manish Singh]

Attachment: Include meta gtk header

With this change (and without the system-header change), I can successfully build with gcc 4.2/

Comment 7

[(not currently active) Ted Mielczarek]

Comment on attachment 285692 [details] [diff] [review]
Include meta gtk header

r=me

Requesting approval1.9, this change should be a no-op, but it fixes a system-headers issue for gcc 4.2 in a clean way.

Comment 8

[Reed Loden [:reed]]

Checking in toolkit/crashreporter/client/crashreporter_linux.cpp;
/cvsroot/mozilla/toolkit/crashreporter/client/crashreporter_linux.cpp,v  <--  crashreporter_linux.cpp
new revision: 1.10; previous revision: 1.9
done