Closed Bug 400621 Opened 13 years ago Closed 13 years ago

Linux crashreporter client has additional system-header dependencies

Categories

(Firefox Build System :: General, defect)

x86
Linux
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
mozilla3 beta1

People

(Reporter: mozbugs, Assigned: mozbugs)

Details

Attachments

(1 file, 1 obsolete file)

Attached patch Add some more gtk headers (obsolete) — Splinter Review
This fixes a build failure I get with gcc 4.2.
Comment on attachment 285676 [details] [diff] [review]
Add some more gtk headers

Ted, are we including all these files explicitly? Is there a meta-header we could use instead (gtk/gtk.h), to avoid having to make this list larger and larget and less manageable?
Attachment #285676 - Flags: review?(ted.mielczarek)
Assignee: nobody → manish
(In reply to comment #1)
> (From update of attachment 285676 [details] [diff] [review])
> Ted, are we including all these files explicitly? Is there a meta-header we
> could use instead (gtk/gtk.h), to avoid having to make this list larger and
> larget and less manageable?

gtk/gtk.h is already in the list.
We are, in fact, and they've been in there for quite some time:
http://bonsai.mozilla.org/cvsblame.cgi?file=/mozilla/toolkit/crashreporter/client
/crashreporter_linux.cpp&rev=1.9&mark=53-68#53

I don't really know anything about GTK, so I can't comment as to whether we could just include one meta-header.
You can certainly just include <gtk/gtk.h> instead of all the files individually. I don't see a rationale for not doing that.

As for them being in there for a while, this worked fine with gcc 4.1, but with gcc 4.2 the build failed due to missing symbols.
Would you care to provide a patch to replace all those includes with that one include?  I don't have gcc 4.2 here, so I can't verify that it works properly.
With this change (and without the system-header change), I can successfully build with gcc 4.2/
Attachment #285676 - Attachment is obsolete: true
Attachment #285676 - Flags: review?(ted.mielczarek)
Attachment #285692 - Flags: review?(ted.mielczarek)
Comment on attachment 285692 [details] [diff] [review]
Include meta gtk header

r=me

Requesting approval1.9, this change should be a no-op, but it fixes a system-headers issue for gcc 4.2 in a clean way.
Attachment #285692 - Flags: review?(ted.mielczarek)
Attachment #285692 - Flags: review+
Attachment #285692 - Flags: approval1.9?
Attachment #285692 - Flags: approvalM9+
Attachment #285692 - Flags: approval1.9?
Attachment #285692 - Flags: approval1.9+
Checking in toolkit/crashreporter/client/crashreporter_linux.cpp;
/cvsroot/mozilla/toolkit/crashreporter/client/crashreporter_linux.cpp,v  <--  crashreporter_linux.cpp
new revision: 1.10; previous revision: 1.9
done
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 3 M9
Component: Build Config → General
Product: Firefox → Firefox Build System
Target Milestone: Firefox 3 beta1 → mozilla3 beta1
You need to log in before you can comment on or make changes to this bug.