Closed Bug 40075 Opened 25 years ago Closed 23 years ago

Redundancy between nsCom.h, nscore.h, nsError.h, nsrootidl.idl

Categories

(Core :: XPCOM, defect, P4)

defect

Tracking

()

RESOLVED FIXED
mozilla1.0

People

(Reporter: braden, Assigned: dougt)

References

Details

(Keywords: arch)

There is a good deal of overlap between nsCom.h, nserror.h, and nsrootidl.idl. The stuff in nsrootidl.idl probably ought to be removed from nsCom.h/nserror.h. I'm not sure what distinction should be drawn between nsCom.h and nserror.h; perhaps they should be merged into a single file. shaver also suggested renaming nsrootidl.idl to the less silly nsroot.idl. Discuss.
I'm not to blame for any of this, and neither is rayw, but he's the XPCOM default owner. /be
Assignee: brendan → rayw
Oops. Brain fart. Not nserror.h, *nscore.h*. Sorry.
Summary: Redundancy between nsCom.h, nserror.h, nsrootidl.idl → Redundancy between nsCom.h, nscore.h, nsrootidl.idl
nsError.h is implicated in all this after all; there's overlap there with nsrootidl.idl in the form of nsresult. More info: The C++ code generated from nsrootidl.idl is #if 0'd out, so it doesn't cause collisions. I'm thinking, why not activate this code and just include nsrootidl.h where these types are needed?
Summary: Redundancy between nsCom.h, nscore.h, nsrootidl.idl → Redundancy between nsCom.h, nscore.h, nsError.h, nsrootidl.idl
moving from architecture to browser product. adding arch keyword
Keywords: arch
Product: Architecture → Browser
QA Contact: nobody → leger
Version: 5.0 → other
Status: NEW → ASSIGNED
Target Milestone: --- → M18
Keywords: nsbeta3
Whiteboard: [nsbeta3+]
nsbeta3-
Whiteboard: [nsbeta3+] → [nsbeta3-]
Edward: Welcome to xpcom!
Status: ASSIGNED → NEW
QA Contact: leger → rayw
Target Milestone: M18 → mozilla1.0
Once again... attempting to reassign from Ray to Edward.
Assignee: rayw → kandrot
Status: NEW → ASSIGNED
Keywords: nsbeta3
Priority: P3 → P4
Whiteboard: [nsbeta3-]
Target Milestone: mozilla1.0 → Future
reassign all kandrot xpcom bug.
Assignee: kandrot → dougt
Status: ASSIGNED → NEW
Target Milestone: Future → ---
Blocks: 70229
Blocks: 98278
Target Milestone: --- → mozilla1.0
I believe that we tackled this with the landing last night. nscore.h is now conceptually the top most headerfile. nsCom.h should be removed eventually. It just points back to nscore. nsrootidl.idl defines most PR* times for xpconnect'ed languages. For C, it points back to nscore.h and also includes prtime.h cause PRTime is defined in the idl. nsError.h, again points to nscore.h and also includes error handling defines. Marking as fixed.
Status: NEW → RESOLVED
Closed: 23 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.