Redundancy between nsCom.h, nscore.h, nsError.h, nsrootidl.idl

RESOLVED FIXED in mozilla1.0

Status

()

Core
XPCOM
P4
normal
RESOLVED FIXED
18 years ago
17 years ago

People

(Reporter: Braden, Assigned: dougt)

Tracking

({arch})

Trunk
mozilla1.0
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

(Reporter)

Description

18 years ago
There is a good deal of overlap between nsCom.h, nserror.h, and nsrootidl.idl.
The stuff in nsrootidl.idl probably ought to be removed from nsCom.h/nserror.h.
I'm not sure what distinction should be drawn between nsCom.h and nserror.h;
perhaps they should be merged into a single file.

shaver also suggested renaming nsrootidl.idl to the less silly nsroot.idl.

Discuss.
I'm not to blame for any of this, and neither is rayw, but he's the XPCOM 
default owner.

/be
Assignee: brendan → rayw
(Reporter)

Comment 2

18 years ago
Oops. Brain fart. Not nserror.h, *nscore.h*. Sorry.
Summary: Redundancy between nsCom.h, nserror.h, nsrootidl.idl → Redundancy between nsCom.h, nscore.h, nsrootidl.idl
(Reporter)

Comment 3

18 years ago
nsError.h is implicated in all this after all; there's overlap there with
nsrootidl.idl in the form of nsresult.

More info: The C++ code generated from nsrootidl.idl is #if 0'd out, so it
doesn't cause collisions. I'm thinking, why not activate this code and just
include nsrootidl.h where these types are needed?
Summary: Redundancy between nsCom.h, nscore.h, nsrootidl.idl → Redundancy between nsCom.h, nscore.h, nsError.h, nsrootidl.idl

Comment 4

18 years ago
moving from architecture to browser product. adding arch keyword
Keywords: arch
Product: Architecture → Browser
QA Contact: nobody → leger
Version: 5.0 → other

Updated

18 years ago
Status: NEW → ASSIGNED
Target Milestone: --- → M18

Updated

18 years ago
Keywords: nsbeta3

Updated

18 years ago
Whiteboard: [nsbeta3+]

Comment 5

18 years ago
nsbeta3-
Whiteboard: [nsbeta3+] → [nsbeta3-]

Comment 6

18 years ago
Edward: Welcome to xpcom!
Status: ASSIGNED → NEW
QA Contact: leger → rayw
Target Milestone: M18 → mozilla1.0

Comment 7

18 years ago
Once again... attempting to reassign from Ray to Edward.
Assignee: rayw → kandrot

Updated

17 years ago
Status: NEW → ASSIGNED
Keywords: nsbeta3
Priority: P3 → P4
Whiteboard: [nsbeta3-]
Target Milestone: mozilla1.0 → Future
(Assignee)

Comment 8

17 years ago
reassign all kandrot xpcom bug.
Assignee: kandrot → dougt
Status: ASSIGNED → NEW
Target Milestone: Future → ---

Updated

17 years ago
Blocks: 70229
(Assignee)

Updated

17 years ago
Blocks: 98278
(Assignee)

Updated

17 years ago
Target Milestone: --- → mozilla1.0
(Assignee)

Comment 9

17 years ago
I believe that we tackled this with the landing last night.

nscore.h is now conceptually the top most headerfile.
nsCom.h should be removed eventually.  It just points back to nscore.
nsrootidl.idl defines most PR* times for xpconnect'ed languages.  For C, it
points back to nscore.h and also includes prtime.h cause PRTime is defined in
the idl.
nsError.h, again points to nscore.h and also includes error handling defines.

Marking as fixed.  
Status: NEW → RESOLVED
Last Resolved: 17 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.