Closed Bug 400759 Opened 14 years ago Closed 14 years ago

PSM should build with NSS size optimization

Categories

(Core :: Security: PSM, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla1.9beta1

People

(Reporter: KaiE, Assigned: KaiE)

References

Details

Attachments

(1 file)

PSM should build with NSS size optimization

Spin off from bug 389781.
Depends on: 389781
Flags: blocking1.9?
Attached patch Patch v1Splinter Review
Attachment #285789 - Flags: review?(rrelyea)
Comment on attachment 285789 [details] [diff] [review]
Patch v1

r+ rrelyea
Attachment #285789 - Flags: review?(rrelyea) → review+
Comment on attachment 285789 [details] [diff] [review]
Patch v1

r=wtc.
Attachment #285789 - Flags: review+
Attachment #285789 - Flags: approval1.9?
The patch for bug 389781 only honors the OPT_CODE_SIZE flag on
Mac, Linux, and Windows.  It would be nice for Mozilla developers
to extend that patch to other platforms.  In particular it should
be easy to extend it to the *BSDs because they all use GCC.
Attachment #285789 - Flags: approvalM9?
Comment on attachment 285789 [details] [diff] [review]
Patch v1

a=endgame drivers for M9
Attachment #285789 - Flags: approvalM9?
Attachment #285789 - Flags: approvalM9+
Attachment #285789 - Flags: approval1.9?
Attachment #285789 - Flags: approval1.9+
landed for M9, marking fixed.
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9 M9
This checkin had absolutely no effect on the Tinderbox codesize numbers.  Then again, I also don't see the NSS things I'd expect to rebuild after this checkin being rebuilt.

Reopening pending that getting sorted out (e.g. with a clobber if that's what's needed).
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Information from Linux clobber:

BEFORE:
Z:14.31MB
mZ:2.719MB

AFTER:
Z:13.94MB
Zdiff:-389954 (+33327/-423281)
mZ:2.372MB
mZdiff:-363554 (+32822/-396376)
Information from Mac clobber:

BEFORE:
Z:14.92MB

AFTER:
Z:14.67MB
Zdiff:-262144 (+68562/-330706)
OK, re-resolving.
Status: REOPENED → RESOLVED
Closed: 14 years ago14 years ago
Resolution: --- → FIXED
Reed, please provide an interpretation of the results you posted.
Z?  mZ?  
Zdiff?  mZdiff?  (are those code size differences?)
Z -- Firefox: Code + data size of all shared libs & executables
mZ -- Embed: Code + data size of all shared libs & executables

The Zdiff and mZdiff display any differences between the last values of Z and mZ and their current values.
For Firefox, the mZ number is irrelevant.  The Z number is the only number that makes sense.

The Z number is the sum of the sizes of the code and data segments (according to readelf, iirc) in all the executables and shared libraries that we actually ship.
You need to log in before you can comment on or make changes to this bug.