400764 - Don't depend on Firefox specifics for notifications for popups and missing plugins

Status: RESOLVED FIXED

(Toolkit :: UI Widgets, defect)

Description

[Teune van Steeg]

User-Agent:       Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.8.1.5) Gecko/20070718 Fedora/2.0.0.5-1.fc7 Firefox/2.0.0.5
Build Identifier: 

pageReports from browser.xml which are used for blocked popups and the missing plugin wizard require a tabbrowser to be available, and the missing plugin wizard also uses the Firefox specific gMissingPluginInstaller.

For SeaMonkey, and maybe other toolkit derived apps, which want to go with a different approach to handle popups and plugins, this is not an ideal situation. 

So those Firefox specific features should be replaced with a more global approach.

Reproducible: Always

Steps to Reproduce:
1.
2.
3.

Comment 1

[Teune van Steeg]

Attachment: depend on browsers instead of tabs.

This patch makes the pageReports from browser.xml and the missing plugin wizard depend on browsers instead of tabs or the tabbrowser.
It also removes the dependency on the Firefox specific gMissingPluginInstaller from the missing plugin wizard and sends an event instead.

Comment 2

[Teune van Steeg]

Attachment: depend on browsers instead of tabs or tabbrowser.

Updated patch

Comment 3

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 289342 [details] [diff] [review]
depend on browsers instead of tabs or tabbrowser.

Sorry for the delay here :(

nit: please .selectedBrowser rather than .mCurrentBrowser for users outside of tabbrowser.

Comment 4

[Teune van Steeg]

Attachment: depend on browsers instead of tabs or tabbrowser. (v2)

Updated patch addressing nit

Comment 5

[Teune van Steeg]

Comment on attachment 293686 [details] [diff] [review]
depend on browsers instead of tabs or tabbrowser. (v2)

This patch contains a few small changes concerning  notifications to the application for popup blocking and finished plugin installation, so that this toolkit code can be shared with SeaMonkey.

Comment 6

[Reed Loden [:reed]]

Checking in toolkit/mozapps/plugins/content/pluginInstallerWizard.js;
/cvsroot/mozilla/toolkit/mozapps/plugins/content/pluginInstallerWizard.js,v  <--  pluginInstallerWizard.js
new revision: 1.22; previous revision: 1.21
done
Checking in toolkit/content/widgets/browser.xml;
/cvsroot/mozilla/toolkit/content/widgets/browser.xml,v  <--  browser.xml
new revision: 1.113; previous revision: 1.112
done
Checking in browser/base/content/browser.js;
/cvsroot/mozilla/browser/base/content/browser.js,v  <--  browser.js
new revision: 1.918; previous revision: 1.917
done
Checking in browser/base/content/tabbrowser.xml;
/cvsroot/mozilla/browser/base/content/tabbrowser.xml,v  <--  tabbrowser.xml
new revision: 1.256; previous revision: 1.255
done