400790 - "ASSERTION: Should not be called" with xul:listbox, xul:listitem

Status: RESOLVED FIXED

(Core :: XUL, defect)

Description

[Jesse Ruderman]

Attachment: testcase

Loading the testcase triggers:

###!!! ASSERTION: Should not be called: 'Not Reached', file /Users/jruderman/trunk/mozilla/layout/xul/base/src/grid/nsGridLayout2.h, line 78

Comment 1

[[e-mail]]

Ah, another of these "should not normally be called" assertions ;-)
sr=me to remove the assertion, if everyone else agrees :-)

Comment 2

[Carsten Book [:Tomcat]]

confirmed on windows debug build ###!!! ASSERTION: Should not be called: 'Not Reached', file c:\work\mozilla\builds\1.9.0-trace-malloc\mozilla\layout\xul\base\src\grid\nsGridLayout2.h, line 78

I see this Assertion also when i open the Places Organizer (Bookmarks -> Organize Bookmarks)

Comment 3

[Martijn Wargers (dead)]

Attachment: removes assertion

So it's ok to remove the assertion, right?

Comment 4

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 290414 [details] [diff] [review]
removes assertion

I think Neil can r+sr this one...

Comment 5

[Martijn Wargers (dead)]

Checking in nsGridLayout2.h;
/cvsroot/mozilla/layout/xul/base/src/grid/nsGridLayout2.h,v  <--  nsGridLayout2.
h
new revision: 1.15; previous revision: 1.14
done

Comment 6

[Ed Lee :Mardak]

Could this have regressed bug 406729?

Comment 7

[Martijn Wargers (dead)]

Well, I just removed an assertion.

Comment 8

[Jesse Ruderman]

Crashtest checked in.