"ASSERTION: Should not be called" with xul:listbox, xul:listitem

RESOLVED FIXED

Status

()

Product:
Core
Component:
XUL
Type:
defect
Status:
RESOLVED FIXED
Opened:
12 years ago
Updated:
11 years ago

People

(Reporter: jruderman, Assigned: martijn.martijn)

Tracking

(Blocks 1 bug, {assertion, testcase})

Version:
Trunk
Platform:
x86
All
Points:
---
Dependency tree / graph
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

testcase
529 bytes, application/vnd.mozilla.xul+xml
Details
removes assertion
1.83 KB, patch
neil
: review+
neil
: superreview+
damons
: approval1.9+
Details | Diff | Splinter Review
Posted file testcase — 
Loading the testcase triggers:

###!!! ASSERTION: Should not be called: 'Not Reached', file /Users/jruderman/trunk/mozilla/layout/xul/base/src/grid/nsGridLayout2.h, line 78
Ah, another of these "should not normally be called" assertions ;-)
sr=me to remove the assertion, if everyone else agrees :-)
confirmed on windows debug build ###!!! ASSERTION: Should not be called: 'Not Reached', file c:\work\mozilla\builds\1.9.0-trace-malloc\mozilla\layout\xul\base\src\grid\nsGridLayout2.h, line 78

I see this Assertion also when i open the Places Organizer (Bookmarks -> Organize Bookmarks)
OS: Mac OS X → All
So it's ok to remove the assertion, right?
Attachment #290414 - Flags: superreview?(bzbarsky)
Attachment #290414 - Flags: review?(neil)
Comment on attachment 290414 [details] [diff] [review]
removes assertion

I think Neil can r+sr this one...
Attachment #290414 - Flags: superreview?(bzbarsky) → superreview?(neil)
Attachment #290414 - Flags: superreview?(neil)
Attachment #290414 - Flags: superreview+
Attachment #290414 - Flags: review?(neil)
Attachment #290414 - Flags: review+
Attachment #290414 - Flags: approval1.9?
Assignee: nobody → martijn.martijn
Attachment #290414 - Flags: approval1.9? → approval1.9+
Checking in nsGridLayout2.h;
/cvsroot/mozilla/layout/xul/base/src/grid/nsGridLayout2.h,v  <--  nsGridLayout2.
h
new revision: 1.15; previous revision: 1.14
done
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Could this have regressed bug 406729?
Well, I just removed an assertion.
Crashtest checked in.
Flags: in-testsuite+
Component: XP Toolkit/Widgets: XUL → XUL
QA Contact: xptoolkit.xul → xptoolkit.widgets
You need to log in before you can comment on or make changes to this bug.