400888 - Larry UI: not part of the tab order, no menu item to open it?

Status: RESOLVED FIXED

(Firefox :: General, defect)

Description

[(not reading, please use [e-mail] instead)]

Larry UI: not part of the tab order, no menu item to open it?

when using tab to cycle between the location bar, search box, tab strip, page elemnts (and back), we skip over the larry box.

additionally, is there a menu item (and command key) to open up the larry UI?

see also a comment from stephend about needing "esc" to close the larry popup.

raising these as potential sec508 / accessibility issues with larry.

Comment 1

[:Gavin Sharp [email: [e-mail]]]

Sec508 is addressed by having Larry information provided in Page Info, which is otherwise accessible, I believe.

Comment 2

[:Gavin Sharp [email: [e-mail]]]

... which doesn't preclude making any improvements to Larry, of course, just want to make sure we're on the same page.

Comment 3

[Aaron Leventhal]

Page info is something that ordinary users almost never visit. Even though it's improved, it's still overwhelming.

But I'm not sure the current entry point into Larry is all that discoverable for mouse users either. I certainly had no idea that the favicon had this new feature. Why would anyone else?

I suggest Larry become a little more "discoverable" and key navigable at the same time. If we can't think of anything which doesn't clutter the UI, then maybe it would be some improvement to put a new item in the context menu for the location bar, and for the page itself. Many people do use the context menu and will notice a new item. That also makes it accessible.

Comment 4

[Johnathan Nightingale [:johnath]]

Aaron - bug 395248 is meant to address a lot of your discoverability concerns - the current presentation is quite flat, and makes the larry box look like just another text field, when really it should look more like a button in chrome - something that invites interaction, and which is clearly distinct from the editable text.

As for accessibility, as Gavin says, there's nothing in Larry that isn't also reachable via Page Info's security tab, which is accessible.  I agree though, that there's nothing saying we can't make larry more accessible, if ideas present themselves. 

Bug 398776 might be a better place to have the conversation though, since my understanding is that once the generic doorhanger support exists, Larry will be subsumed by it, and an accessible way to open the door hanger alerts in general is probably better than something Larry-specific.

Comment 5

[Aaron Leventhal]

This button is important enough to be added to the tab order and have proper semantics (a role of button and an accessible name from the tooltiptext). Security is clearly important enough that it shouldn't be hidden away in page info, and that goes for non-disabled users as well. Most users simply don't go into that dialog, even if they are advanced.

From the technical side, adding this to the tab order is not completely trivial, because it's a child of the autocomplete, and the autocomplete textbox has some way of stealing focus from it. Either it needs to become a previous sibling from the autocomplete, or we have to figure out how to keep focus from getting stolen.

The semantics of the button are getting fixed in bug 407359.

Comment 6

[Aaron Leventhal]

Fix checked in with bug 407359.

Comment 7

[Firefox Bug Husbandry Bot]

https://bugzilla.mozilla.org/show_bug.cgi?id=1527381