400924 - star / bookmark dialog: click to close

Status: VERIFIED FIXED

(Firefox :: Bookmarks & History, defect, P2)

Description

[(not reading, please use [e-mail] instead)]

star dialog:  click to close

on windows xp, clicking on the star button (that you clicked on to bookmark a page) doesn't close it.

clicking elsewhere does close it.

note, this is not an issue on mac.

this is very much like "Larry UI: click to close" bug that johnath fixed today.

see bug #395314 for his solution.

Just as that bug was a blocker, I think we should block on this one, too.

Comment 1

[Asaf Romano (gone)]

Attachment: patch

Comment 2

[(not reading, please use [e-mail] instead)]

Comment on attachment 286773 [details] [diff] [review]
patch

r=sspitzer

mano, king of memoization!

Comment 3

[(not reading, please use [e-mail] instead)]

Comment on attachment 286773 [details] [diff] [review]
patch

while testing, found that this didn't work.

but mano has a version that does.

Comment 4

[Asaf Romano (gone)]

Attachment: v2

Comment 5

[(not reading, please use [e-mail] instead)]

Comment on attachment 286776 [details] [diff] [review]
v2

r=sspitzer (tested it on windows xp)

Comment 6

[Asaf Romano (gone)]

mozilla/browser/base/content/browser-places.js 1.58

Comment 7

[Carsten Book [:Tomcat]]

verified fixed using  Mozilla/5.0 (Windows; U; Windows NT 5.2; en-US; rv:1.9a9pre) Gecko/2007110103 Minefield/3.0a9pre and the steps to reproduce from seth in comment #0

-> verified

Comment 8

[Gervase Markham [:gerv]]

Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv