star / bookmark dialog: click to close

VERIFIED FIXED in Firefox 3 beta1

Status

()

Firefox
Bookmarks & History
P2
normal
VERIFIED FIXED
11 years ago
9 years ago

People

(Reporter: (not reading, please use seth@sspitzer.org instead), Assigned: mano)

Tracking

Trunk
Firefox 3 beta1
x86
Windows XP
Points:
---
Bug Flags:
blocking-firefox3 +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

star dialog:  click to close

on windows xp, clicking on the star button (that you clicked on to bookmark a page) doesn't close it.

clicking elsewhere does close it.

note, this is not an issue on mac.

this is very much like "Larry UI: click to close" bug that johnath fixed today.

see bug #395314 for his solution.

Just as that bug was a blocker, I think we should block on this one, too.
Flags: blocking-firefox3?
Summary: star dialog: click to close → star / bookmark dialog: click to close

Updated

11 years ago
Assignee: nobody → mano
Flags: blocking-firefox3? → blocking-firefox3+
Status: NEW → ASSIGNED
Priority: -- → P2
Comment on attachment 286773 [details] [diff] [review]
patch

r=sspitzer

mano, king of memoization!
Attachment #286773 - Flags: review?(sspitzer) → review+
Comment on attachment 286773 [details] [diff] [review]
patch

while testing, found that this didn't work.

but mano has a version that does.
Attachment #286773 - Flags: review+
Attachment #286773 - Flags: approvalM9?
Created attachment 286776 [details] [diff] [review]
v2
Attachment #286773 - Attachment is obsolete: true
Attachment #286776 - Flags: review?(sspitzer)
Attachment #286776 - Flags: approvalM9?
Attachment #286776 - Attachment is patch: true
Attachment #286776 - Attachment mime type: application/octet-stream → text/plain
Comment on attachment 286776 [details] [diff] [review]
v2

r=sspitzer (tested it on windows xp)
Attachment #286776 - Flags: review?(sspitzer) → review+

Updated

11 years ago
Attachment #286776 - Flags: approvalM9? → approvalM9+
mozilla/browser/base/content/browser-places.js 1.58
Status: ASSIGNED → RESOLVED
Last Resolved: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 3 M9
verified fixed using  Mozilla/5.0 (Windows; U; Windows NT 5.2; en-US; rv:1.9a9pre) Gecko/2007110103 Minefield/3.0a9pre and the steps to reproduce from seth in comment #0

-> verified
Status: RESOLVED → VERIFIED
Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv
Component: Places → Bookmarks & History
QA Contact: places → bookmarks
You need to log in before you can comment on or make changes to this bug.