Need to provide a way to modify and create new PKCS #11 objects.

RESOLVED FIXED in 3.12

Status

NSS
Libraries
P1
enhancement
RESOLVED FIXED
10 years ago
10 years ago

People

(Reporter: Robert Relyea, Assigned: Robert Relyea)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 3 obsolete attachments)

(Assignee)

Description

10 years ago
Some applications need to modify PKCS #11 objects directly, particularly management applications for those pkcs #11 modules. We already have a way to fetch generic objects and read their attributes, we also need a way to create objects and modify their attributes.

Currently this is needed for nsscompatossl layer to manage pem file.
(Assignee)

Comment 1

10 years ago
Created attachment 286074 [details] [diff] [review]
Implement 2 new functions, one to create new attributes and the other to write them.
Attachment #286074 - Flags: review?
(Assignee)

Updated

10 years ago
Attachment #286074 - Flags: review? → review?(julien.pierre.boogz)

Comment 2

10 years ago
Comment on attachment 286074 [details] [diff] [review]
Implement 2 new functions, one to create new attributes and the other to write them.

I'm not crazy about the void* objSpec argument for PK11_WriteRawAttribute .
But it looks like the damage was already done in PK11_ReadRawAttribute, so we should make those functions consistent.

Please add some documentation to the header files about the format of objspec, ie. the various structures that PK11ObjectType enum values map to. A good place to put that might be in the enum definition, but the comment for the raw functions should explain that the format of the structure is determined by the type.
Attachment #286074 - Flags: review?(julien.pierre.boogz) → review-
(Assignee)

Comment 3

10 years ago
Created attachment 286769 [details] [diff] [review]
version2: update comments as requested.

Update the comments
Attachment #286074 - Attachment is obsolete: true
Attachment #286769 - Flags: review?
(Assignee)

Comment 4

10 years ago
Comment on attachment 286769 [details] [diff] [review]
version2: update comments as requested.

This patch as some cruft, obsoleting..
Attachment #286769 - Attachment is obsolete: true
Attachment #286769 - Flags: review?
(Assignee)

Comment 5

10 years ago
Created attachment 286772 [details] [diff] [review]
v3: all the comments, none of the cruft.
(Assignee)

Comment 6

10 years ago
Created attachment 286774 [details] [diff] [review]
4th time's a charm (sigh)
Attachment #286772 - Attachment is obsolete: true
(Assignee)

Comment 7

10 years ago
Comment on attachment 286774 [details] [diff] [review]
4th time's a charm (sigh)

ok, julian, this should be it. interdiff will give you the correct diffs, but mislabel the files.
Attachment #286774 - Flags: review?(julien.pierre.boogz)

Comment 8

10 years ago
Comment on attachment 286774 [details] [diff] [review]
4th time's a charm (sigh)

This looks fine. I am not crazy about interdiff anyway. Manual diff of diff works better.
Attachment #286774 - Flags: review?(julien.pierre.boogz) → review+

Updated

10 years ago
Target Milestone: --- → 3.12
Version: 3.12 → trunk
(Assignee)

Updated

10 years ago
Duplicate of this bug: 402711
(Assignee)

Comment 10

10 years ago
+128/4) Lines changed.
When 	Who 	File 	Rev 	+/- 	Description
2007-10-31 10:25	rrelyea%redhat.com 	mozilla/security/nss/lib/nss/nss.def 	1.181 	2/0  	

Need to provide a way to modify and create new PKCS #11 objects.
bug 401026
r=julien

Implements 2 new functions, one to modify existing pkcs #11 objects, and
another to creat them.
2007-10-31 10:25	rrelyea%redhat.com 	mozilla/security/nss/lib/pk11wrap/pk11obj.c 	1.18 	92/2 
2007-10-31 10:25	rrelyea%redhat.com 	mozilla/security/nss/lib/pk11wrap/pk11pub.h 	1.19 	24/0 
2007-10-31 10:25	rrelyea%redhat.com 	mozilla/security/nss/lib/pk11wrap/secmodi.h 	1.25 	1/1 
2007-10-31 10:25	rrelyea%redhat.com 	mozilla/security/nss/lib/pk11wrap/secmodt.h 	1.34 	9/1 

Status: NEW → RESOLVED
Last Resolved: 10 years ago
Priority: -- → P1
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.