401026 - Need to provide a way to modify and create new PKCS #11 objects.

Status: RESOLVED FIXED

(NSS :: Libraries, enhancement, P1)

Description

[Robert Relyea]

Some applications need to modify PKCS #11 objects directly, particularly management applications for those pkcs #11 modules. We already have a way to fetch generic objects and read their attributes, we also need a way to create objects and modify their attributes.

Currently this is needed for nsscompatossl layer to manage pem file.

Comment 1

[Robert Relyea]

Attachment: Implement 2 new functions, one to create new attributes and the other to write them.

Comment 2

[Julien Pierre]

Comment on attachment 286074 [details] [diff] [review]
Implement 2 new functions, one to create new attributes and the other to write them.

I'm not crazy about the void* objSpec argument for PK11_WriteRawAttribute .
But it looks like the damage was already done in PK11_ReadRawAttribute, so we should make those functions consistent.

Please add some documentation to the header files about the format of objspec, ie. the various structures that PK11ObjectType enum values map to. A good place to put that might be in the enum definition, but the comment for the raw functions should explain that the format of the structure is determined by the type.

Comment 3

[Robert Relyea]

Attachment: version2: update comments as requested.

Update the comments

Comment 4

[Robert Relyea]

Comment on attachment 286769 [details] [diff] [review]
version2: update comments as requested.

This patch as some cruft, obsoleting..

Comment 5

[Robert Relyea]

Attachment: v3: all the comments, none of the cruft.

Comment 6

[Robert Relyea]

Attachment: 4th time's a charm (sigh)

Comment 7

[Robert Relyea]

Comment on attachment 286774 [details] [diff] [review]
4th time's a charm (sigh)

ok, julian, this should be it. interdiff will give you the correct diffs, but mislabel the files.

Comment 8

[Julien Pierre]

Comment on attachment 286774 [details] [diff] [review]
4th time's a charm (sigh)

This looks fine. I am not crazy about interdiff anyway. Manual diff of diff works better.

Comment 10

[Robert Relyea]

+128/4) Lines changed.
When 	Who 	File 	Rev 	+/- 	Description
2007-10-31 10:25	rrelyea%redhat.com 	mozilla/security/nss/lib/nss/nss.def 	1.181 	2/0  	

Need to provide a way to modify and create new PKCS #11 objects.
bug 401026
r=julien

Implements 2 new functions, one to modify existing pkcs #11 objects, and
another to creat them.
2007-10-31 10:25	rrelyea%redhat.com 	mozilla/security/nss/lib/pk11wrap/pk11obj.c 	1.18 	92/2 
2007-10-31 10:25	rrelyea%redhat.com 	mozilla/security/nss/lib/pk11wrap/pk11pub.h 	1.19 	24/0 
2007-10-31 10:25	rrelyea%redhat.com 	mozilla/security/nss/lib/pk11wrap/secmodi.h 	1.25 	1/1 
2007-10-31 10:25	rrelyea%redhat.com 	mozilla/security/nss/lib/pk11wrap/secmodt.h 	1.34 	9/1