401079 - Building accessible without XUL fails

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Description

[Oleg Romashin (:romaxa)]

Small ifdef in nsAccessibleEventData.cpp required to

Comment 1

[Benjamin Smedberg]

Dare I ask why you need to build accessible for a phone?

Comment 2

[Oleg Romashin (:romaxa)]

Attachment: Missing patch for bugreport

Comment 3

[Oleg Romashin (:romaxa)]

This is not about phone, this is about minimal build, which contain by default enabled ACCESSIBILITY ... and which fails to build because there are no ifdef.

Probably we can disable ACCESSIBILITY from minimal build...

Comment 4

[Benjamin Smedberg]

I think that's preferable, unless there's a reason to keep it.

Comment 5

[Aaron Leventhal]

Disabling XUL used to work. We've put effort into making it build with XUL disabled, and we should maintain that.

Comment 6

[Aaron Leventhal]

Comment on attachment 286154 [details] [diff] [review]
Missing patch for bugreport

What was the error message? We should still be able to use the text interface when XUL is not being built.

Comment 7

[Oleg Romashin (:romaxa)]

Attachment: Right fix

Oh, yep, there are was just not defined nsIAccessibleText

This should be better...

Comment 8

[Reed Loden [:reed]]

Please do not add checkin-needed to bugs that do not have approval for the patches.

Comment 9

[Reed Loden [:reed]]

Checking in accessible/src/base/nsAccessibleEventData.cpp;
/cvsroot/mozilla/accessible/src/base/nsAccessibleEventData.cpp,v  <--  nsAccessibleEventData.cpp
new revision: 1.23; previous revision: 1.22
done

Comment 10

[timeless]

for the record, disabling it in general isn't a good idea, even maemo is probably likely to use atk (and does for testing).