Closed Bug 401079 Opened 14 years ago Closed 14 years ago
Building accessible without XUL fails
Small ifdef in nsAccessibleEventData.cpp required to
Dare I ask why you need to build accessible for a phone?
Assignee: nobody → aaronleventhal
Component: Build Config → Disability Access APIs
Product: Toolkit → Core
QA Contact: build-config → accessibility-apis
This is not about phone, this is about minimal build, which contain by default enabled ACCESSIBILITY ... and which fails to build because there are no ifdef. Probably we can disable ACCESSIBILITY from minimal build...
Attachment #286154 - Flags: review?(surkov.alexander)
I think that's preferable, unless there's a reason to keep it.
Disabling XUL used to work. We've put effort into making it build with XUL disabled, and we should maintain that.
Comment on attachment 286154 [details] [diff] [review] Missing patch for bugreport What was the error message? We should still be able to use the text interface when XUL is not being built.
Attachment #286154 - Flags: review?(surkov.alexander) → review-
Oh, yep, there are was just not defined nsIAccessibleText This should be better...
Attachment #286154 - Attachment is obsolete: true
Attachment #286296 - Flags: review?(aaronleventhal)
Attachment #286296 - Flags: review?(aaronleventhal) → review+
Please do not add checkin-needed to bugs that do not have approval for the patches.
Assignee: aaronleventhal → romaxa
Attachment #286296 - Flags: approval1.9? → approval1.9+
Checking in accessible/src/base/nsAccessibleEventData.cpp; /cvsroot/mozilla/accessible/src/base/nsAccessibleEventData.cpp,v <-- nsAccessibleEventData.cpp new revision: 1.23; previous revision: 1.22 done
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Summary: Building accessible without XUL fails. → Building accessible without XUL fails
Target Milestone: --- → mozilla1.9 M10
for the record, disabling it in general isn't a good idea, even maemo is probably likely to use atk (and does for testing).
You need to log in before you can comment on or make changes to this bug.