401093 - Do not force restart when installing unknown add-on types

Status: RESOLVED FIXED

(Toolkit :: Add-ons Manager, enhancement)

Description

[Wladimir Palant]

ExtensionManager.installRequiresRestart() currently always returns true - unless the add-on is a theme and some special conditions are met. Unfortunately, returning true for unknown (application-defined) add-on types is a bad assumption, the restart is probably now required. I see two options:

1. Always return false for unknown add-on types and let the application itself deal with restarts.
2. Introduce a new (optional) field in install.rdf to allow overriding the restart preference.

The first option is much simpler so I would go for it unless there is a good reason to implement a different solution.

Comment 1

[Wladimir Palant]

Attachment: Proposed patch

Comment 2

[Robert Strong (they/them - no direct email)]

Comment on attachment 286153 [details] [diff] [review]
Proposed patch

Good call. Thanks Wladimir

Comment 3

[Reed Loden [:reed]]

Checking in toolkit/mozapps/extensions/src/nsExtensionManager.js.in;
/cvsroot/mozilla/toolkit/mozapps/extensions/src/nsExtensionManager.js.in,v  <--  nsExtensionManager.js.in
new revision: 1.259; previous revision: 1.258
done

Comment 4

[Reed Loden [:reed]]

Comment on attachment 286153 [details] [diff] [review]
Proposed patch

>+    return ((type & nsIUpdateItem.TYPE_ANY) > 0);

This caused test oranges because of the missing "Ci." before "nsIUpdateItem.TYPE_ANY" (should have been Ci.nsIUpdateItem.TYPE_ANY).

Comment 5

[Wladimir Palant]

Reed - thanks for fixing this. My tree didn't have bug 395311 patch, it removed the global nsIUpdateItem constant.