401190 - nsNavHistory should implement nsIDownloadHistory

Status: RESOLVED FIXED

(Firefox :: Bookmarks & History, defect, P4)

Description

[Shawn Wilsher :sdwilsh]

Bug 401174 adds a new interface, nsIDownloadHistory, that is used to track the history of downloads.  nsNavHistory should implement it and override the version in docshell/base so that we have the proper transition type, TRANSITION_DOWNLOAD and any other information we may want to track down the line.

Comment 1

[Shawn Wilsher :sdwilsh]

Attachment: 0.1

work in progress - at least until we get Bug 400544 fixed.

Comment 2

[Shawn Wilsher :sdwilsh]

Requesting blocking since this blocks a blocker (Bug 390491).

Comment 3

[Shawn Wilsher :sdwilsh]

Attachment: v0.2

Not there yet - attaching to get feedback on assertion I'm getting.

Comment 4

[Shawn Wilsher :sdwilsh]

Attachment: v1.0

It works!  CID needs to be the same :)

Comment 5

[Dietrich Ayala (:dietrich)]

Comment on attachment 294289 [details] [diff] [review]
v1.0


>+// main
>+function run_test() {
>+  // Test that when we get nsIDownloadHistory that it's the one places
>+  // implements.
>+  var dh = Cc["@mozilla.org/browser/download-history;1"].
>+           getService(Ci.nsIDownloadHistory);
>+  do_check_true(dh instanceof Ci.nsINavHistoryService);
>+
>+  // no to make sure all the functionality works!

mega-nit: s/no/now/

Comment 6

[Shawn Wilsher :sdwilsh]

Attachment: v1.1

hehe, mega-nit indeed :)

Comment 7

[Shawn Wilsher :sdwilsh]

Checking in toolkit/components/places/src/nsNavHistory.cpp;
new revision: 1.219; previous revision: 1.218
Checking in toolkit/components/places/src/nsNavHistory.h;
new revision: 1.118; previous revision: 1.117
Checking in toolkit/components/places/src/nsPlacesModule.cpp;
new revision: 1.5; previous revision: 1.4
Checking in toolkit/components/places/tests/unit/test_download_history.js;
initial revision: 1.1

Comment 8

[Gervase Markham [:gerv]]

Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv