401215 - Background banding for the download manager

Status: VERIFIED FIXED

(Toolkit :: Downloads API, defect)

Description

[Michael Ventnor]

Attachment: Patch

In the mockup each download has alternating backgrounds to make them easier to separate.

Comment 2

[Shawn Wilsher :sdwilsh]

Requesting the blocking that Bug 392109 had...

Comment 3

[Shawn Wilsher :sdwilsh]

Comment on attachment 286271 [details] [diff] [review]
Patch

> /**
>+ * Gives every second cell an odd attribute so they can receive alternating
>+ * backgrounds from the stylesheets.
>+ */
>+function evenOddCellAttribution()
>+{
>+  var alternateCell = false;
>+  var allDownloadsInView = gDownloadsView.getElementsByTagName("richlistitem");
>+  var currentNode;
>+
>+  for (var i = 0; i < allDownloadsInView.length; i++) {
use let here please

>+    if (currentNode.getAttribute("type") != "download")
>+      continue;
this shouldn't be necessary.

>Index: toolkit/themes/pinstripe/mozapps/downloads/downloads.css
>+richlistitem[type="download"][alternate="true"]:not([selected="true"]) {
>+  background-color: ThreeDLightShadow;
>+}
This isn't correct for the mac.  Please see the discussion in Bug 392109 - perhaps Colin can help clarify the correct colors.

Comment 4

[Colin Barrett [:cbarrett]]

See http://mxr.mozilla.org/seamonkey/source/widget/src/cocoa/nsLookAndFeel.mm

We probably should look at using NSColor for some of those. Particularly:

+ (NSArray *)controlAlternatingRowBackgroundColors

Returns an array containing the system specified background colors for alternating rows in tables and lists. You should not assume the array will contain only two colors. For general information on system colors, see “Accessing System Colors”.

Honestly, it might be better to just hardcode light blue, and leave it up to themes to change this if they are themeing the entire OS.

CC'ing Josh to see if we want to do anything about this.

Comment 5

[Michael Ventnor]

Attachment: Patch 2

For now this hardcodes the same blue as Safari's DL manager. This could probably make it for M9...

Comment 6

[Shawn Wilsher :sdwilsh]

(In reply to comment #4)
> We probably should look at using NSColor for some of those. Particularly:
Can we get that stuff from CSS?

Comment 7

[Shawn Wilsher :sdwilsh]

Attachment: active downloads screenshot (mac)

Comment 8

[Shawn Wilsher :sdwilsh]

Attachment: completed downloads screenshot (mac)

Comment 9

[Shawn Wilsher :sdwilsh]

Comment on attachment 286356 [details] [diff] [review]
Patch 2

This would in fact be nice to have for the beta.

r=sdwilsh

Comment 10

[Colin Barrett [:cbarrett]]

(In reply to comment #6)
> (In reply to comment #4)
> > We probably should look at using NSColor for some of those. Particularly:
> Can we get that stuff from CSS?
> 

That's what I was talking about implementing. From the way I'm reading the current code, it doesn't look like there's anything like that in there.

Comment 11

[Shawn Wilsher :sdwilsh]

I'm inclined to fix that in a follow-up bug then.

Comment 12

[Shawn Wilsher :sdwilsh]

This patch no longer applies cleanly.

Comment 13

[Michael Ventnor]

Attachment: Unbitrot

Comment 14

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 286446 [details] [diff] [review]
Unbitrot

a=endgame drivers are fine for M9, please do file the followup patch for non-hard-coded CSS in pinstripe

Comment 15

[Reed Loden [:reed]]

Checking in toolkit/mozapps/downloads/content/downloads.js;
/cvsroot/mozilla/toolkit/mozapps/downloads/content/downloads.js,v  <--  downloads.js
new revision: 1.97; previous revision: 1.96
done
Checking in toolkit/themes/pinstripe/mozapps/downloads/downloads.css;
/cvsroot/mozilla/toolkit/themes/pinstripe/mozapps/downloads/downloads.css,v  <--  downloads.css
new revision: 1.19; previous revision: 1.18
done
Checking in toolkit/themes/winstripe/mozapps/downloads/downloads.css;
/cvsroot/mozilla/toolkit/themes/winstripe/mozapps/downloads/downloads.css,v  <--  downloads.css
new revision: 1.23; previous revision: 1.22
done

Comment 16

[Stephen Donner [:stephend] Not actively reading bugmail]

I grabbed tinderbox builds from: ftp://ftp.mozilla.org/pub/firefox/tinderbox-builds;

Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9a9pre) Gecko/2007102913 Minefield/3.0a9pre

Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9a9pre) Gecko/2007102912 Minefield/3.0a9pre

and

Mozilla/5.0 (Macintosh; U; Intel Mac OS X; en-US; rv:1.9a9pre) Gecko/2007102913 Minefield/3.0a9pre

Verified FIXED; I made sure to check both downloading and 'completed' states.

Comment 17

[Steve England [:stevee]]

Attachment: The striping is too dark on Windows imo

Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9a9pre) Gecko/2007103004 Minefield/3.0a9pre ID:2007103004

I think the striping is too dark.

Comment 18

[Peter van der Woude [:Peter6]]

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a9pre) Gecko/2007103010 Minefield/3.0a9pre ID:2007103010

No offense, but this looks absolutely horrible and is inconsistent with other parts of FF's UI.

Why don't we use a gray dotted border to separate the downloads ?
Same as how in the in add-ons manager ,Extensions,Themes and Plugins are separated.

Comment 19

[Stephen Donner [:stephend] Not actively reading bugmail]

Please file spin-off bugs; thanks.

Comment 20

[Peter van der Woude [:Peter6]]

(In reply to comment #19)
> Please file spin-off bugs; thanks.
> 

->Bug 401774