Closed Bug 401220 Opened 12 years ago Closed 12 years ago

"Zoom In" and "Zoom Out" are interchanged in help.dtd

Categories

(SeaMonkey :: Help Viewer, defect)

defect
Not set

Tracking

(Not tracked)

VERIFIED FIXED
mozilla1.9beta1

People

(Reporter: dao, Assigned: dao)

References

Details

Attachments

(1 file)

Attached patch patchSplinter Review
see bug 389628 comment 135
Flags: blocking1.9?
Attachment #286273 - Flags: review?(mano)
Comment on attachment 286273 [details] [diff] [review]
patch

I think it'd better rev the entities to ...zooom/In/Out.. as well.

r=mano either way.
Attachment #286273 - Flags: review?(mano) → review+
Comment on attachment 286273 [details] [diff] [review]
patch

(In reply to comment #1)
Hrm, yes, might be a little bit clearer ... but it would also mean to change more similar entities and the code that's using them.
Attachment #286273 - Flags: approvalM9?
I think the policy is you shouldn't change the meaning of an entity without changing its name, so that the localizers know what to review.

Would it be hard to change all those similar entities?
If this will be commited ASAP, I think entity name change isn't needed. According to buildbot, only our (sk) locale was updated after landing bug 389628 and we will fix this in our locale today.
(In reply to comment #3)
> I think the policy is you shouldn't change the meaning of an entity without
> changing its name, so that the localizers know what to review.

Note that the meaning of the entities remains the same, I'm fixing a bug in the en-US strings.

> Would it be hard to change all those similar entities?

It wouldn't be precisely hard, but a relatively much bigger patch, with the (low) risk of new regressions.
Comment on attachment 286273 [details] [diff] [review]
patch

a=beltzner for M9
Attachment #286273 - Flags: approvalM9? → approvalM9+
Flags: blocking1.9? → blocking1.9+
Checking in toolkit/locales/en-US/chrome/mozapps/help/help.dtd;
/cvsroot/mozilla/toolkit/locales/en-US/chrome/mozapps/help/help.dtd,v  <--  help.dtd
new revision: 1.9; previous revision: 1.8
done

If somebody can help make sure some locale doesn't get confused by this, we'd really appreciate it. Thanks!
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Verified FIXED via code inspection, using MXR to poke Bonsai (http://bonsai.mozilla.org/cvslog.cgi?file=/mozilla/toolkit/locales/en-US/chrome/mozapps/help/help.dtd&rev=HEAD&mark=1.9):

1.9	reed%reedloden.com	2007-10-26 06:47	 	Bug 401220 - ""Zoom In" and "Zoom Out" are interchanged in help.dtd" [p=dao r=Mano aM9=beltzner]
Status: RESOLVED → VERIFIED
Product: Toolkit → Seamonkey
You need to log in before you can comment on or make changes to this bug.