Closed Bug 401312 Opened 17 years ago Closed 17 years ago

[10.5] Give the status bar the correct look on Leopard

Categories

(Camino Graveyard :: OS Integration, defect)

Product:
Camino Graveyard
Component:
OS Integration
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
VERIFIED FIXED
Milestone:
Camino1.6

People

(Reporter: stuart.morgan+bugzilla, Assigned: stuart.morgan+bugzilla)

References

Details

(Keywords: fixed1.8.1.10, Whiteboard: [camino-1.5.4])

Attachments

(2 files, 1 obsolete file)

v2
8.57 KB, patch
froodian
: review+
mark
: superreview+
Details | Diff | Splinter Review
1_5 branch version
6.08 KB, patch
Details | Diff | Splinter Review
Attached patch fix (obsolete) — — Splinter Review 
This gives the status bar the rounded, textured look on Leopard, and etches the status bar text. The aqua progress bar is a bit odd there, but that's a problem for another day; that's less of an issue than the light, square status bar amidst a sea of Leopard windows.
Flags: camino1.5.4?
Attachment #286347 - Flags: review?(Jeff.Dlouhy)
Attached patch v2 — — Splinter Review 
Whoops, now with the rest of the fix.
Attachment #286347 - Attachment is obsolete: true
Attachment #286351 - Flags: review?(Jeff.Dlouhy)
Attachment #286347 - Flags: review?(Jeff.Dlouhy)
Comment on attachment 286351 [details] [diff] [review]
v2

Unfortunately, the |setContentBorderThickness| call causes a momentary dark grey flash when opening every new tab.  Not really sure of a way around that though, and the code looks good, so r=me.
Attachment #286351 - Flags: review?(Jeff.Dlouhy) → review+
Attachment #286351 - Flags: superreview?(mikepinkerton)
Blocks: 401340
Screenshot, please?
Just look at a screenshot of the status bar in Safari on Leopard (or any other app on 10.5, really)
Summary: Give the status bar the correct look on Leopard → [10.5] Give the status bar the correct look on Leopard
Attachment #286351 - Flags: superreview?(mikepinkerton) → superreview+
Landed on trunk and MOZILLA_1_8_BRANCH.
Status: NEW → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
Verified fixed on trunk and MOZILLA_1_8_BRANCH.
Status: RESOLVED → VERIFIED
This doesn't apply cleanly on the 1_5 branch, and BWC hunk 3 has a lot of changes in context, so I didn't feel comfortable just pasting in the new code.

If we do want this for 1.5.4, someone more knowledgeable than me will need to do the backport.
Flags: camino1.5.4? → camino1.5.4+
I can't conveniently build and test this at the moment, but it should be correct for the 1_5 branch.
Comment on attachment 289078 [details] [diff] [review]
1_5 branch version

Looks good/works OK here on 10.5 and 10.3.9.  I don't notice any Console spew (not sure what else to "test" for).
Attachment #289078 - Attachment is patch: true
Attachment #289078 - Attachment mime type: application/octet-stream → text/plain
Landed on CAMINO_1_5_BRANCH. Thanks for the testing :)
Whiteboard: [camino-1.5.4]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: