[10.5] Give the status bar the correct look on Leopard

VERIFIED FIXED in Camino1.6

Status

Camino Graveyard
OS Integration
VERIFIED FIXED
10 years ago
10 years ago

People

(Reporter: Stuart Morgan, Assigned: Stuart Morgan)

Tracking

({fixed1.8.1.10})

unspecified
Camino1.6
x86
Mac OS X
fixed1.8.1.10

Details

(Whiteboard: [camino-1.5.4])

Attachments

(2 attachments, 1 obsolete attachment)

v2
8.57 KB, patch
froodian (Ian Leue)
: review+
Mark Mentovai
: superreview+
Details | Diff | Splinter Review
6.08 KB, patch
Details | Diff | Splinter Review
(Assignee)

Description

10 years ago
Created attachment 286347 [details] [diff] [review]
fix

This gives the status bar the rounded, textured look on Leopard, and etches the status bar text. The aqua progress bar is a bit odd there, but that's a problem for another day; that's less of an issue than the light, square status bar amidst a sea of Leopard windows.
Flags: camino1.5.4?
Attachment #286347 - Flags: review?(Jeff.Dlouhy)
(Assignee)

Comment 1

10 years ago
Created attachment 286351 [details] [diff] [review]
v2

Whoops, now with the rest of the fix.
Attachment #286347 - Attachment is obsolete: true
Attachment #286351 - Flags: review?(Jeff.Dlouhy)
Attachment #286347 - Flags: review?(Jeff.Dlouhy)

Comment 2

10 years ago
Comment on attachment 286351 [details] [diff] [review]
v2

Unfortunately, the |setContentBorderThickness| call causes a momentary dark grey flash when opening every new tab.  Not really sure of a way around that though, and the code looks good, so r=me.
Attachment #286351 - Flags: review?(Jeff.Dlouhy) → review+
(Assignee)

Updated

10 years ago
Attachment #286351 - Flags: superreview?(mikepinkerton)

Updated

10 years ago
Blocks: 401340

Comment 3

10 years ago
Screenshot, please?

Comment 4

10 years ago
Just look at a screenshot of the status bar in Safari on Leopard (or any other app on 10.5, really)

Comment 5

10 years ago
https://bugzilla.mozilla.org/attachment.cgi?id=286415 demonstrates this
Summary: Give the status bar the correct look on Leopard → [10.5] Give the status bar the correct look on Leopard

Updated

10 years ago
Attachment #286351 - Flags: superreview?(mikepinkerton) → superreview+
(Assignee)

Comment 6

10 years ago
Landed on trunk and MOZILLA_1_8_BRANCH.
Status: NEW → RESOLVED
Last Resolved: 10 years ago
Resolution: --- → FIXED
Keywords: fixed1.8.1.10

Comment 7

10 years ago
Verified fixed on trunk and MOZILLA_1_8_BRANCH.
Status: RESOLVED → VERIFIED
This doesn't apply cleanly on the 1_5 branch, and BWC hunk 3 has a lot of changes in context, so I didn't feel comfortable just pasting in the new code.

If we do want this for 1.5.4, someone more knowledgeable than me will need to do the backport.
Flags: camino1.5.4? → camino1.5.4+
(Assignee)

Comment 9

10 years ago
Created attachment 289078 [details] [diff] [review]
1_5 branch version

I can't conveniently build and test this at the moment, but it should be correct for the 1_5 branch.
Comment on attachment 289078 [details] [diff] [review]
1_5 branch version

Looks good/works OK here on 10.5 and 10.3.9.  I don't notice any Console spew (not sure what else to "test" for).
Attachment #289078 - Attachment is patch: true
Attachment #289078 - Attachment mime type: application/octet-stream → text/plain
(Assignee)

Comment 11

10 years ago
Landed on CAMINO_1_5_BRANCH. Thanks for the testing :)
Whiteboard: [camino-1.5.4]
You need to log in before you can comment on or make changes to this bug.