This gives the status bar the rounded, textured look on Leopard, and etches the status bar text. The aqua progress bar is a bit odd there, but that's a problem for another day; that's less of an issue than the light, square status bar amidst a sea of Leopard windows.
Attachment #286347 - Flags: review?(Jeff.Dlouhy)
Whoops, now with the rest of the fix.
Comment on attachment 286351 [details] [diff] [review] v2 Unfortunately, the |setContentBorderThickness| call causes a momentary dark grey flash when opening every new tab. Not really sure of a way around that though, and the code looks good, so r=me.
Attachment #286351 - Flags: review?(Jeff.Dlouhy) → review+
Attachment #286351 - Flags: superreview?(mikepinkerton)
Just look at a screenshot of the status bar in Safari on Leopard (or any other app on 10.5, really)
https://bugzilla.mozilla.org/attachment.cgi?id=286415 demonstrates this
Summary: Give the status bar the correct look on Leopard → [10.5] Give the status bar the correct look on Leopard
Attachment #286351 - Flags: superreview?(mikepinkerton) → superreview+
Landed on trunk and MOZILLA_1_8_BRANCH.
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Verified fixed on trunk and MOZILLA_1_8_BRANCH.
Status: RESOLVED → VERIFIED
This doesn't apply cleanly on the 1_5 branch, and BWC hunk 3 has a lot of changes in context, so I didn't feel comfortable just pasting in the new code. If we do want this for 1.5.4, someone more knowledgeable than me will need to do the backport.
Flags: camino1.5.4? → camino1.5.4+
I can't conveniently build and test this at the moment, but it should be correct for the 1_5 branch.
Comment on attachment 289078 [details] [diff] [review] 1_5 branch version Looks good/works OK here on 10.5 and 10.3.9. I don't notice any Console spew (not sure what else to "test" for).
Landed on CAMINO_1_5_BRANCH. Thanks for the testing :)
You need to log in before you can comment on or make changes to this bug.