401385 - Livemarks folders in fx3 show no changes when open, despite coding for it.

Status: VERIFIED FIXED

(Firefox :: Bookmarks & History, defect, P4)

Description

[Ed Hume]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a9pre) Gecko/2007102504 Minefield/3.0a9pre
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a9pre) Gecko/2007102504 Minefield/3.0a9pre

When there is a livemarks folder item on a toolbar or in a menu, opening the folder (to reveal the items in a submenu) does not cause any change in the livemarks folder icon.

Reproducible: Always

Steps to Reproduce:
1. Subscribe to a page with livemarks
2. Put the resulting livemarks folder item on a toolbar or menu.
3. Click on the livemarks folder item.
Actual Results:  
No image change

Expected Results:  
Image should change.

Relevant code is lines 235-243 in browser.css

Comment 1

[Ria Klaassen (not reading all bugmail)]

Hard to see the difference, but the regression range is http://bonsai.mozilla.org/cvsquery.cgi?module=PhoenixTinderbox&date=explicit&mindate=1192080720&maxdate=1192085459

Comment 2

[Ria Klaassen (not reading all bugmail)]

Setting the blocking flag as a reminder.

Comment 3

[mcdavis941 (sporadically reading bugmail)]

I wonder if this has anything to do with feed icon representation changing from Fx2 to Fx3.  (Before: list-style-image.  Now: as attribute on DOM element.)

Combine this with a policy that a list-style-image doesn't get drawn when there's a favicon present (to keep from obscuring the favicon), and now the feed icon never changes either.  It just displays the one hard-coded icon.

Bookmark Type               Value of image Attribute
-------------------------   --------------------------------------------

** Fx2 in Bookmarks Toolbar Only **

Live Bookmark Folder        - does not have image attr -
Bookmark Folder             - does not have image attr -
Page, with Favicon          data:image/x-icon;base-64,AAABAAEA ...
Page, no Favicon            image=""
Image only by Chrome URL    image=""

** Fx3 in Bookmarks Toolbar Only **

Live Bookmark Folder        chrome://browser/skin/places/livemarkItem.png
Bookmark Folder             - does not have image attr -
Page, with Favicon          moz-anno:favicon:http://www.mozilla.org/im ...
Page, no Favicon            - does not have image attr -
Image only by Chrome URL    - does not have image attr -
about:config                - does not have image attr -


Attributes on Live Bookmark Toolbarbutton in Bookmarks Toolbar
--------------------------------------------------------------

** Fx2 **

- note no image attribute -
id="rdf:whatever"
container="true"
type="menu"
class="bookmark-item"
editable="true"
type="http://home.netscape.com/NC ..."
label="whatever"
livemark="true"
chromedir="ltr"

** Fx3 **

class="bookmark-item"
label="whatever"
image="chrome://browser/skin/places/livemarkItem.png"
type="menu"
container="true"
livemark="true"

Comment 4

[Asaf Romano (gone)]

Is this still reproducible on trunk? I'm pretty sure this was fixed by bug 387746.

Comment 5

[Ria Klaassen (not reading all bugmail)]

WFM with Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9b2pre) Gecko/2007112208 Minefield/3.0b2pre

Comment 6

[Asaf Romano (gone)]

Fixed then.

Comment 7

[Ed Hume]

Yup. Fixed. And thank you.

Comment 8

[Tracy Walker [:tracy]]

(In reply to comment #7)
> Yup. Fixed. And thank you.
> 

marking verified per reporters comment

Comment 9

[Gervase Markham [:gerv]]

Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv