Closed Bug 401388 Opened 17 years ago Closed 17 years ago

Help viewer filters filtered datasources

Categories

(SeaMonkey :: Help Viewer, defect)

defect
Not set
minor

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: neil, Assigned: neil)

References

Details

(Keywords: perf)

Attachments

(1 file)

SeaMonkey includes a datasource help-win.rdf using an nc:platform directive in suitehelp.rdf but toolkit's help viewer still filters the datasource's nodes.
Attached patch Proposed patchSplinter Review
* Set the default platform to null
* Null-check the platform test
* Null-check the platform before filtering
Assignee: jwalden+fxhelp → neil
Status: NEW → ASSIGNED
Attachment #286417 - Flags: review?(jwalden+fxhelp)
Attachment #286417 - Flags: review?(jwalden+fxhelp) → review?(jwalden+bmo)
Comment on attachment 286417 [details] [diff] [review]
Proposed patch

This looks good, particularly because I remember it better from having written/modified it.  :-)
Attachment #286417 - Flags: review?(jwalden+bmo) → review+
Fix checked in.
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
Blocks: 409533
Product: Toolkit → Seamonkey
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: