Closed
Bug 401402
Opened 19 years ago
Closed 19 years ago
De-get-ify interfaces
Categories
(Camino Graveyard :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
Camino1.6
People
(Reporter: stuart.morgan+bugzilla, Assigned: stuart.morgan+bugzilla)
Details
(Keywords: fixed1.8.1.10)
Attachments
(2 files)
|
132.52 KB,
patch
|
mark
:
superreview+
|
Details | Diff | Splinter Review |
|
133.23 KB,
patch
|
Details | Diff | Splinter Review |
This removes almost all of the un-cocoa-y "get"s from our Cocoa APIs. The (very notable) exception is the suite of pref getters. Those I left for another time since a) we need to re-think the withSuccess parameter as well, and b) we should probably leave compatibility shims in place for the people who wrote pref panes and (legitimately) expected to be able to use those methods.
No behavioral changes, just naming. I'll just do a branch version at checkin time; given the likelyhood of minor bitrotting to this patch before it lands I'd rather not double my work.
Attachment #286434 -
Flags: superreview?(mark)
|
||
Comment 1•19 years ago
|
||
Comment on attachment 286434 [details] [diff] [review]
trunk fix
This looks like it was a huge and annoying job. Way to save us a few columns of horizontal space!
Attachment #286434 -
Flags: superreview?(mark) → superreview+
|
Assignee | |
Comment 2•19 years ago
|
||
Landed on trunk and MOZILLA_1_8_BRANCH.
I apologize in advance for any patches I rot, but the good news is that just fixing the patches themselves will be really easy.
Status: NEW → RESOLVED
Closed: 19 years ago
Keywords: fixed1.8.1.10
Resolution: --- → FIXED
Target Milestone: --- → Camino1.6
|
|
Assignee | |
Comment 3•19 years ago
|
||
as landed
You need to log in
before you can comment on or make changes to this bug.
Description
•