401552 - Returning from fullscreenmode with minimized toolbar, bookmark-bar and menu-bar produces 5 instead of 3 "grip" buttons

Status: RESOLVED FIXED

(SeaMonkey :: UI Design, defect)

Description

[Christoph]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.8) Gecko/20071009 SeaMonkey/1.1.5
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.8) Gecko/20071009 SeaMonkey/1.1.5

Switching to fullscreen via `F11' with all the UI elements minimized results later  switching back again in more maximize buttons (in total 5).

Reproducible: Always

Steps to Reproduce:
1. Minimize all UI elements (navigation toolbar, menubar, bookmark ...)
2. Switch to fullscreen and back
Actual Results:  
Observed more maximize buttons.

Expected Results:  
Show just the three buttons like before switching to fullscreen

I am using the classic theme. Vanilla build, directly downlaoded from the homepage. Present extensions: flashplayer, adblock plus. All with vanilla config.

Comment 1

[Arun Prasannan (polar)]

Confirmed on trunk:

* The navigation toolbar behaves correctly
* When returning to normal mode, the menubar and site navigation bar are expanded, and minimised grippies displayed as well.

Comment 2

[Serge Gautherie (:sgautherie)]

[Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9a5pre) Gecko/20070515 SeaMonkey/1.5a] (nightly) (W2Ksp4)
[Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9pre) Gecko/2008061402 SeaMonkey/2.0a1pre] (nightly) (W2Ksp4)

Confirming (comment 1):
*no extensions
*both themes

Affected:
Menu Bar
Personal Toolbar
Site Navigation Bar [which has bug 439312 too]

Working:
Navigation Toolbar

Comment 3

[Tony Mechelynck [:tonymec]]

Mozilla/5.0 (X11; Linux x86_64; rv:2.0.2pre) Gecko/20110517 Firefox/4.0.2pre SeaMonkey/2.1.1pre
no extensions (other than the built-in ones)
tested only with default theme

Setting Platform to All.

On Linux, I see four grippies on return from full-screen mode, instead of the "expected" three. The extra grippy comes from the menubar (collapsing the menubar by means of its grippy, then hitting F11 twice, produces 2 grippies in collapsed position). Behaviour of the other two bars is OK. The two menubar grippies both say "Menu Bar" when hovered in collapsed state, but after expanding one of them, clicking the other simply makes it disappear.

Tentatively moving this bug to UI Design. Neil, if I goofed, go ahead and move it where it belongs.

Comment 4

[Tony Mechelynck [:tonymec]]

P.S. when hitting F11 repeatedly with the menubar collapsed, I see one additional grippy every time I come back out of fullscreen. If the other toolbars are also collapsed they don't exhibit such behaviour.

Comment 5

[therube]

Having the File menu bar collapsed seem to be the precipitater to this.
(I.e. having the other menu bars, other then File, closed does not cause this to occur.)

Mozilla/5.0 (Windows NT 5.1; rv:2.0.1) Gecko/20110511 Firefox/4.0.1 SeaMonkey/2.1


This does not occur in SeaMonkey 2.0.

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1.19) Gecko/20110420 SeaMonkey/2.0.14

Comment 6

[[e-mail]]

Attachment: Minimal patch [Checkin: comments 8 and 10]

Going in or out of full screen changes the menubar's binding, so when we exit full screen we try to create the collapsed grippy again.

Comment 7

[[e-mail]]

Attachment: Possible patch

Some of the grippy code looked like it could use some cleanup.

Comment 8

[[e-mail]]

Pushed changeset 33dd068ac121 to comm-central.

Comment 9

[[e-mail]]

Comment on attachment 553167 [details] [diff] [review]
Minimal patch [Checkin: comments 8 and 10]

Probably not significant enough a regression for beta so just trying aurora.

Comment 10

[Jens Hatlak (:InvisibleSmiley)]

Comment on attachment 553167 [details] [diff] [review]
Minimal patch [Checkin: comments 8 and 10]

http://hg.mozilla.org/releases/comm-aurora/rev/2c601ad0b4d0