401556 - Ambiguous label in Prefs > Advanced > Network when clearing the cache

Status: VERIFIED FIXED

(Firefox :: Settings UI, defect)

Description

[Frédéric Buclin]

Attachment: screenshot

In Prefs > Private, you have a button labelled "Clear data now", and the same label is displayed in Prefs > Advanced > Network about clearing the cache. In the latter case, this label is ambiguous as it makes me think it's going to clear all my data, not only the cache. I suggest we rename the label to "Clear cache" or something like that. Unless it really clears everything too?? See, I'm not even sure what this button does.

Comment 1

[:Gavin Sharp [email: [e-mail]]]

Yeah, these use the same localized string. The French localizers used a more specific string for the button text ("Clear my tracks now") than en-US ("Clear Now"). I suppose this could be fixed by changing the french locale, but it would probably be a good idea to use separate entities here.

Comment 2

[Benoit]

There is no good way to fix the French locale as long as the same entity is used in both cases. To make a long story short, in French "Clear" is not really the same as "Empty" (it depends on the subject, you can clear your tracks but not a container like the cache), and both are transitive: Clear /what/? How does one clear a "Now"?.

The current label is the best compromize that could be found with only one entity, as Privacy preferences are more likely to be used than Advanced preferences.

Comment 3

[Benoit]

Attachment: Use a separate entity in the Advanced pref pane

Let's try this.

Comment 4

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 287222 [details] [diff] [review]
Use a separate entity in the Advanced pref pane

Merci! :)

Comment 5

[Reed Loden [:reed]]

Checking in browser/components/preferences/advanced.xul;
/cvsroot/mozilla/browser/components/preferences/advanced.xul,v  <--  advanced.xul
new revision: 1.41; previous revision: 1.40
done
Checking in browser/locales/en-US/chrome/browser/preferences/advanced.dtd;
/cvsroot/mozilla/browser/locales/en-US/chrome/browser/preferences/advanced.dtd,v  <--  advanced.dtd
new revision: 1.26; previous revision: 1.25
done

Comment 6

[Aleksei Perepelkin [:chaos]]

Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9b2pre) Gecko/2007112704 Minefield/3.0b2pre

for clear cache button used &clearCacheNow.label;

Verified Fixed

Comment 7

[[:Aleksej]]

Per comment 6.