Closed Bug 401559 Opened 14 years ago Closed 14 years ago

GetFirst/LastChild doesn't ensure contents generated

Categories

(Core :: XUL, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: neil, Assigned: smaug)

References

Details

(Keywords: regression)

Attachments

(1 file)

Bug 198533 removed the XUL-specific implementations of GetFirst/LastChild that call GetChildAt/Count that call EnsureContentsGenerated. Was this intentional?
No, that was not intended, IIRC.
Either those methods should be put back to nsXULElement or
nsGenericElement::GetFirs/LastChild should use GetChildAt
Attached patch proposed patchSplinter Review
I think code clarity is more important than extra virtual call, so changing nsGenericElement, not nsXULElement
Assignee: nobody → Olli.Pettay
Status: NEW → ASSIGNED
Attachment #286564 - Flags: review?(neil)
Attachment #286564 - Flags: review?(neil) → review+
Attachment #286564 - Flags: superreview?(jst)
Attachment #286564 - Flags: superreview?(jst) → superreview+
Comment on attachment 286564 [details] [diff] [review]
proposed patch

this is fixing a regression, um, from 1.7.
Not needed for M9.
Attachment #286564 - Flags: approval1.9?
But would be great to have fixed in 1.9.
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Component: XP Toolkit/Widgets: XUL → XUL
QA Contact: xptoolkit.xul → xptoolkit.widgets
You need to log in before you can comment on or make changes to this bug.