Closed
Bug 401559
Opened 17 years ago
Closed 17 years ago
GetFirst/LastChild doesn't ensure contents generated
Categories
(Core :: XUL, defect)
Core
XUL
Tracking
()
RESOLVED
FIXED
People
(Reporter: neil, Assigned: smaug)
References
Details
(Keywords: regression)
Attachments
(1 file)
|
1.16 KB,
patch
|
neil
:
review+
jst
:
superreview+
roc
:
approval1.9+
|
Details | Diff | Splinter Review |
Bug 198533 removed the XUL-specific implementations of GetFirst/LastChild that call GetChildAt/Count that call EnsureContentsGenerated. Was this intentional?
|
Assignee | |
Comment 1•17 years ago
|
||
No, that was not intended, IIRC. Either those methods should be put back to nsXULElement or nsGenericElement::GetFirs/LastChild should use GetChildAt
|
|
Assignee | |
Comment 2•17 years ago
|
||
I think code clarity is more important than extra virtual call, so changing nsGenericElement, not nsXULElement
|
Reporter | |
Updated•17 years ago
|
Attachment #286564 -
Flags: review?(neil) → review+
|
|
Assignee | |
Updated•17 years ago
|
Attachment #286564 -
Flags: superreview?(jst)
|
||
Updated•17 years ago
|
Attachment #286564 -
Flags: superreview?(jst) → superreview+
|
|
Assignee | |
Comment 3•17 years ago
|
||
Comment on attachment 286564 [details] [diff] [review] proposed patch this is fixing a regression, um, from 1.7. Not needed for M9.
Attachment #286564 -
Flags: approval1.9?
|
|
Assignee | |
Comment 4•17 years ago
|
||
But would be great to have fixed in 1.9.
Attachment #286564 -
Flags: approval1.9? → approval1.9+
|
|
Assignee | |
Updated•17 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
Component: XP Toolkit/Widgets: XUL → XUL
QA Contact: xptoolkit.xul → xptoolkit.widgets
You need to log in
before you can comment on or make changes to this bug.
Description
•