Closed Bug 401739 Opened 17 years ago Closed 17 years ago

Thunderbird always starts in Calendar Mode

Categories

(Calendar :: Lightning Only, defect)

defect
Not set
normal

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: ssitter, Assigned: Fallen)

References

Details

(Keywords: regression)

Attachments

(1 file, 1 obsolete file)

Thunderbird always starts in Calendar Mode

Steps to Reproduce:
1. Install Lightning
2. Switch to Mail Mode or Calendar Mode
3. Restart Thunderbird

Actual Results:
Thunderbird always starts in Calendar Mode.

Expected Results:
Thunderbird starts in Mail Mode except a command line flag was used to start in Calendar Mode (see e.g. Bug 359807).

Regression Range:
WORKS using Lightning 0.8pre (2007102909) + Thunderbird 2.0.0.7pre (20071030)
FAILS using Lightning 0.8pre (2007103004) + Thunderbird 2.0.0.7pre (20071030)

Checkins during regression range: http://tinyurl.com/2fddl9
Possible causer: Bug 401521
Flags: blocking-calendar0.8+
Attached patch Fix v1 (obsolete) — Splinter Review
Argh...I have the feeling I'm breaking more than I am fixing.

Please test at least on one platform, in case my testing missed something like last time...
Assignee: nobody → philipp
Status: NEW → ASSIGNED
Attachment #286816 - Flags: review?(michael.buettner)
Attached patch patch v2Splinter Review
Your patch looks just fine and works as advertised. But since it attempts to restructure the view/mode switching logic, I find that there are some bits and pieces missing.

LtnObserveDisplayDeckChange(), see [1], should not contain any logic besides that it should detect that the mail panel gets notified but we're still in calendar mode. In that case it should switch back to mail mode. All the logic should live in the different ltnSwitch2...() functions.

Please find the attached patch with the above comment already being addressed.

[1] http://lxr.mozilla.org/mozilla1.8/source/calendar/lightning/content/messenger-overlay-sidebar.js#505
Attachment #286816 - Attachment is obsolete: true
Attachment #286951 - Flags: review?(philipp)
Attachment #286816 - Flags: review?(michael.buettner)
Blocks: 401521
Comment on attachment 286951 [details] [diff] [review]
patch v2

>+    // Switch back to mail mode in case we find that this
>+    // notification has been fired but we're still in calendar mode.
>     if (id != "calendar-view-box") {
>         if (gCurrentMode != 'mail') {
>             ltnSwitch2Mail();
>         }
>     }
Go ahead and put this into one if()


Otherwise r=philipp. Do you want to do the checkin or should I?
Attachment #286951 - Flags: review?(philipp) → review+
patch checked in on trunk and MOZILLA_1_8_BRANCH

-> FIXED
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
OS: Windows 2000 → All
Hardware: PC → All
Target Milestone: --- → 0.8
Verified in nightly build 20071108, task is fixed.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.