401781 - Add tests for nsI*Stream

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Description

[Alex Vincent [:WeirdAl]]

Attachment: initial test file

Binary, string, async, scriptable, converters, tees, multiplexes, seekable, unichar...

This first test is for binary streams.  (I needed to learn how to do them anyway.  I also need to write a test for binary sockets, but that's under netwerk.)

Comment 1

[Alex Vincent [:WeirdAl]]

tests only, shouldn't need approval

Comment 2

[Reed Loden [:reed]]

RCS file: /cvsroot/mozilla/xpcom/tests/unit/test_streams.js,v
done
Checking in xpcom/tests/unit/test_streams.js;
/cvsroot/mozilla/xpcom/tests/unit/test_streams.js,v  <--  test_streams.js
initial revision: 1.1
done

Comment 3

[Reed Loden [:reed]]

This test caused orange on the unit test boxen after it was checked-in.

*** CHECK FAILED: -0.22227387432800896 == 1.4142135623730951

Offending lines:
  os.writeDouble(Math.SQRT2);
  do_check_eq(is.readDouble(), Math.SQRT2);

Commenting these lines out makes the test pass. bz thinks it may actually be a bug in the streams. He is going to look tomorrow.

Comment 4

[Mark Banner (:standard8)]

(In reply to comment #3)
> Commenting these lines out makes the test pass. bz thinks it may actually be a
> bug in the streams. He is going to look tomorrow.

Interestingly, this test is still failing on the SeaMonkey linux tinderbox:

*** CHECK FAILED: -0.02285707593528823 == 1.4142135623730951
  JS frame :: /builds/tinderbox/SeaMonkey-Trunk/Linux_2.6.18-8.el5_Depend/mozilla/tools/test-harness/xpcshell-simple/head.js :: do_throw :: line 99
  JS frame :: /builds/tinderbox/SeaMonkey-Trunk/Linux_2.6.18-8.el5_Depend/mozilla/tools/test-harness/xpcshell-simple/head.js :: do_check_eq :: line 114
  JS frame :: ../../_tests/xpcshell-simple/xpcom/unit/test_streams.js :: test_binary_streams :: line 138
  JS frame :: ../../_tests/xpcshell-simple/xpcom/unit/test_streams.js :: run_test :: line 183
  JS frame :: /builds/tinderbox/SeaMonkey-Trunk/Linux_2.6.18-8.el5_Depend/mozilla/tools/test-harness/xpcshell-simple/tail.js :: _execute_test :: line 41
  JS frame :: /builds/tinderbox/SeaMonkey-Trunk/Linux_2.6.18-8.el5_Depend/mozilla/tools/test-harness/xpcshell-simple/execute_test.js :: <TOP_LEVEL> :: line 38
  2147500036
  *** FAIL ***

looks like line 138: 

do_check_eq(is.readDouble(), Math.SQRT2);

needs commenting out as well.

Somehow the Firefox tinderbox is passing despite this...

Comment 5

[Robert Kaiser]

This blocks SeaMonkey from getting nightly builds at the moment.

Comment 6

[Robert Kaiser]

Of course, the matching .writeDouble() also needs to be commented out.

I checked in comments for those lines (119 and 138) as well with r+sr=biesi in #developers so that SeaMonkey can go green and build nightlies.

Something definitely is wrong here though, maybe even a real stream failure detected by the test.

Comment 7

[Boris Zbarsky [:bzbarsky]]

Unfortunately, I can't reproduce the breakage locally.  :(  So not much I can do here.

Comment 8

[Alex Vincent [:WeirdAl]]

bz: do you want a new bug filed for this test bustage?

Comment 9

[Boris Zbarsky [:bzbarsky]]

Yes.  And it would be great if someone can reproduce...