Closed
Bug 401796
Opened 17 years ago
Closed 17 years ago
nsIStringCharsetDetector.h should not include nsString.h
Categories
(Core :: Internationalization, defect)
Core
Internationalization
Tracking
()
RESOLVED
FIXED
mozilla1.9beta2
People
(Reporter: mook, Assigned: mook)
References
()
Details
Attachments
(1 file)
|
1.03 KB,
patch
|
smontagu
:
review+
damons
:
approval1.9+
|
Details | Diff | Splinter Review |
nsIStringCharsetDetector.h #includes nsString.h, but never uses anything from it (it uses char*, PRUint32, and an enum in another file, plus nsISupports and other basic XPCOM things). This makes it hard to use from external API, even though it works just fine. Yes, it's in $dist/xulrunner/include/chardet. Too bad it ended up not being useful on account of the strings I'm feeding it being too short :)
Attachment #286764 -
Flags: review?(smontagu)
|
||
Comment 1•17 years ago
|
||
Comment on attachment 286764 [details] [diff] [review] remove #include <nsString.h> r+moa=me
Attachment #286764 -
Flags: review?(smontagu) → review+
|
Assignee | |
Comment 2•17 years ago
|
||
Comment on attachment 286764 [details] [diff] [review] remove #include <nsString.h> very, very low risk (if it doesn't work, it will break the build); works on TryServer. Doesn't matter enough to get into M9, but is a good idea in general.
Attachment #286764 -
Flags: approval1.9?
|
||
Updated•17 years ago
|
Attachment #286764 -
Flags: approval1.9? → approval1.9+
|
||
Updated•17 years ago
|
Keywords: checkin-needed
|
|
||
Comment 3•17 years ago
|
||
Checking in intl/chardet/public/nsIStringCharsetDetector.h; /cvsroot/mozilla/intl/chardet/public/nsIStringCharsetDetector.h,v <-- nsIStringCharsetDetector.h new revision: 1.12; previous revision: 1.11 done
Status: NEW → RESOLVED
Closed: 17 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9 M10
You need to log in
before you can comment on or make changes to this bug.
Description
•