support building with dtrace enabled on Mac OS X

RESOLVED FIXED in mozilla1.9beta1

Status

()

Core
Build Config
--
enhancement
RESOLVED FIXED
10 years ago
10 years ago

People

(Reporter: myk, Assigned: rflint)

Tracking

Trunk
mozilla1.9beta1
All
Mac OS X
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Reporter)

Description

10 years ago
Now that Mac OS X 10.5 includes support for dtrace, we should support building with dtrace enabled on that OS.  According to Adam Leventhal in a blog post <http://blogs.sun.com/ahl/entry/dtrace_firefox_leopard>, it's not too tricky, and he has a patch.  Ryan Flint also has a patch <http://screwedbydesign.com/mozilla/dtracemac.diff>.

Comment 1

10 years ago
Ryan's patch looks good; just two comments:

It seems like it would be a good idea to change the polarity of the condition (if !MACOSX) since FreeBSD and other ports are, I'd argue, likely to be in the model of Solaris _and_ Mac OS X will hopefully implement -G at least as a no-op (apple bug <rdar://problem/5566030>).

I think it's worth noting in the change to the provider D file that it's a work around for apple's bugs: <rdar://problem/5194316> <rdar://problem/5565198>
Created attachment 286883 [details] [diff] [review]
Patch

Same patch with Adam's comments addressed.
Attachment #286883 - Flags: review?(ted.mielczarek)
Created attachment 286886 [details] [diff] [review]
The right patch

Bah, It'd probably be helpful if I gave these unique names before attaching them.
Attachment #286883 - Attachment is obsolete: true
Attachment #286886 - Flags: review?(ted.mielczarek)
Attachment #286883 - Flags: review?(ted.mielczarek)
Comment on attachment 286886 [details] [diff] [review]
The right patch

I can't say I fully understand how DTrace works, but this just comments out the calls to dtrace from the build process.  What are we losing from that?

Comment 5

10 years ago
The calls eliminated are superfluous on Leopard (needed by Solaris)
Attachment #286886 - Flags: review?(ted.mielczarek) → review+
Comment on attachment 286886 [details] [diff] [review]
The right patch

Drivers: this is a nearly zero risk patch (only changes code built with --enable-dtrace) that will allow our developers and others on Leopard to utilize DTrace - which is immensely useful for our ongoing performance efforts.
Attachment #286886 - Flags: approvalM9?

Comment 7

10 years ago
Comment on attachment 286886 [details] [diff] [review]
The right patch

a+ as we don't ship with --enable-dtrace by default (thus NPOTDB) but useful for devs anyway
Attachment #286886 - Flags: approvalM9? → approvalM9+
Assignee: nobody → rflint
Keywords: checkin-needed
Target Milestone: --- → mozilla1.9 M9
Checking in config/rules.mk;
/cvsroot/mozilla/config/rules.mk,v  <--  rules.mk
new revision: 3.576; previous revision: 3.575
done
Checking in js/src/Makefile.in;
/cvsroot/mozilla/js/src/Makefile.in,v  <--  Makefile.in
new revision: 3.113; previous revision: 3.112
done
Checking in js/src/javascript-trace.d;
/cvsroot/mozilla/js/src/javascript-trace.d,v  <--  javascript-trace.d
new revision: 3.2; previous revision: 3.1
done
Status: NEW → RESOLVED
Last Resolved: 10 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Version: unspecified → Trunk
You need to log in before you can comment on or make changes to this bug.