401817 - [10.5] Can't build Camino with 10.5 SDK: error: 'MAXPATHLEN' was not declared in this scope

Status: RESOLVED FIXED

(Camino Graveyard :: General, defect)

Description

[Mark Mentovai]

While building Camino (trunk or Cm1.6-M1.8):

CompileC build/Camino.build/Deployment/DownloadsPrefPane.build/Objects-normal/i386/Downloads.o /lizard/trunk/build/camino-shared-10.5/camino/src/preferences/../../PreferencePanes/Downloads/Downloads.mm normal i386 objective-c++ com.apple.compilers.gcc.4_0
    cd /lizard/trunk/build/camino-shared-10.5/camino
    /Developer/usr/bin/gcc-4.0 -x objective-c++ -arch i386 -pipe -Wno-trigraphs -fno-exceptions -fno-rtti -fpascal-strings -fasm-blocks -O2 -Wuninitialized -Wsign-compare -DOSTYPE=Darwin1.4 -DOSARCH=Darwin -DMOZILLA_INTERNAL_API=1 -fmessage-length=0 -fvisibility-inlines-hidden -mmacosx-version-min=10.5 -I/lizard/trunk/build/camino-shared-10.5/camino/build/Camino.build/Deployment/DownloadsPrefPane.build/Downloads.hmap -Wall -Wno-four-char-constants -O2 -F/lizard/trunk/build/camino-shared-10.5/camino/build/Deployment -I/lizard/trunk/build/camino-shared-10.5/camino/build/Deployment/include -I../dist/include/nkcache -I../dist/include/webbrwsr -I../dist/include/dom -I../dist/include/nspr -I../dist/include/string -I../dist/include/rdf -I../dist/include/necko -I../dist/include/find -I../dist/include/embed_base -I../dist/include/windowwatcher -I../dist/include/webshell -I../dist/include/widget -I../dist/include/uriloader -I../dist/include/docshell -I../dist/include/profile -I../dist/include/layout -I../dist/include/content -I../dist/include/webbrowserpersist -I../dist/include/pref -I../dist/include/mimetype -I../dist/include/shistory -I../dist/include/history -I../dist/include/view -I../dist/include/gfx -I../dist/include/xultmpl -I../dist/include/xmlextras -I../dist/include/htmlparser -I../dist/include/locale -I../dist/include/unicharutil -I../dist/include/appcomps -I../dist/include/xpcom -I../dist/include -I/Developer/SDKs/MacOSX10.5.sdk/Developer/Headers/FlatCarbon -I/lizard/trunk/build/camino-shared-10.5/camino/build/Camino.build/Deployment/DownloadsPrefPane.build/DerivedSources -fshort-wchar -Wno-non-virtual-dtor -isysroot /Developer/SDKs/MacOSX10.5.sdk -include /lizard/trunk/build/camino-shared-10.5/camino/src/includes/ChimeraPrefix.h -c /lizard/trunk/build/camino-shared-10.5/camino/src/preferences/../../PreferencePanes/Downloads/Downloads.mm -o /lizard/trunk/build/camino-shared-10.5/camino/build/Camino.build/Deployment/DownloadsPrefPane.build/Objects-normal/i386/Downloads.o
/lizard/trunk/build/camino-shared-10.5/camino/src/preferences/../../PreferencePanes/Downloads/Downloads.mm: In function 'NSString* -[OrgMozillaChimeraPreferenceDownloads getDownloadFolderDescription](OrgMozillaChimeraPreferenceDownloads*, objc_selector*)':
/lizard/trunk/build/camino-shared-10.5/camino/src/preferences/../../PreferencePanes/Downloads/Downloads.mm:151: error: 'MAXPATHLEN' was not declared in this scope
/lizard/trunk/build/camino-shared-10.5/camino/src/preferences/../../PreferencePanes/Downloads/Downloads.mm:152: error: 'utf8path' was not declared in this scope
** BUILD FAILED **
make[4]: *** [libs] Error 1
make[4]: Leaving directory `/lizard/trunk/build/camino-shared-10.5/camino'
make[3]: *** [libs_tier_app] Error 2
make[3]: Leaving directory `/lizard/trunk/build/camino-shared-10.5'
make[2]: *** [tier_app] Error 2
make[2]: Leaving directory `/lizard/trunk/build/camino-shared-10.5'
make[1]: *** [alldep] Error 2
make[1]: Leaving directory `/lizard/trunk/build/camino-shared-10.5'
make: *** [alldep] Error 2
make: Leaving directory `/lizard/trunk/mozilla'

MAXPATHLEN is defined in <sys/param.h> to be identical to PATH_MAX.  This definition is still present in the 10.5 SDK, but apparently, the standard Carbon and Cocoa headers no longer bring in that definition.

Chasing down exactly what changed is pointless.  This whole thing is silly.  PATH_MAX is the more commonly used equivalent anyway, and that just works fine, so let's use it.

Comment 1

[Mark Mentovai]

Attachment: Use PATH_MAX instead of MAXPATHLEN

Comment 2

[Mark Mentovai]

Checked in on the trunk and MOZILLA_1_8_BRANCH prior to 1.6a1.