Closed
Bug 40185
Opened 25 years ago
Closed 23 years ago
need to review nsPluginInstanceOwner::GetHeight()
Categories
(Core :: Layout, defect, P4)
Tracking
()
RESOLVED
FIXED
mozilla1.0
People
(Reporter: buster, Assigned: peterlubczynski-bugs)
References
()
Details
(Whiteboard: [beppe:10/11/01])
Attachments
(1 file)
|
3.60 KB,
patch
|
serhunt
:
review+
attinasi
:
superreview+
asa
:
approval+
|
Details | Diff | Splinter Review |
nsPluginInstanceOwner::GetHeight() and nsPluginInstanceOwner::GetWidth() do some
questionable math to try to account for margins. We need to review the intent
of this code, and possibly fix it. I fixed bug 35777, but I'm not completely
comfortable with the result.
|
Assignee | |
Comment 1•24 years ago
|
||
Marc,
Perhpas this is related or caused by bug 72427? Lots of block code and Buster
says to check it out--->over to you.
Assignee: av → attinasi
|
||
Comment 2•23 years ago
|
||
minor issue, setting to future
Priority: P3 → P4
Whiteboard: [beppe:10/11/01]
Target Milestone: --- → Future
|
|
Assignee | |
Comment 4•23 years ago
|
||
This code was so ugly I have to attach this patch.
|
|
Assignee | |
Updated•23 years ago
|
Comment on attachment 74621 [details] [diff] [review]
patch using mPluginWindow.height
Wow! r=av
Attachment #74621 -
Flags: review+
|
||
Comment 6•23 years ago
|
||
Comment on attachment 74621 [details] [diff] [review]
patch using mPluginWindow.height
sr=attinasi
Attachment #74621 -
Flags: superreview+
|
||
Comment 7•23 years ago
|
||
Comment on attachment 74621 [details] [diff] [review]
patch using mPluginWindow.height
a=asa (on behalf of drivers) for checkin to the 1.0 trunk
Attachment #74621 -
Flags: approval+
|
|
Assignee | |
Comment 8•23 years ago
|
||
patch in trunk, marking FIXED
Status: ASSIGNED → RESOLVED
Closed: 23 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.0
You need to log in
before you can comment on or make changes to this bug.
Description
•