401850 - Unable to save two copies of the same file; unique-filename-generation stuff is broken

Status: VERIFIED WORKSFORME

(Toolkit :: Downloads API, defect, P4)

Description

[Stephen Donner [:stephend] Not actively reading bugmail]

Attachment: Screenshot

Summary: Unable to save two copies of the same file; unique-filename-generation stuff is broken

It appears our unique-naming stuff has broken :-(

Steps to Reproduce:

1. Download two copies of the same file, such as loading http://www.mozilla.com/en-US/ and clicking the green "Download" button once, then refreshing and clicking "Save As..."
2. Wait for the first download to finish (it succeeds)
3. Wait for the second download to attempt to finish (it fails)

This regressed, but I don't yet know when; I'll post a screenshot

Comment 1

[Stephen Donner [:stephend] Not actively reading bugmail]

Mac-only, which is weird.

Comment 2

[Benjamin Smedberg]

Marking blocking+ to at least get this on the M9 endgame radar.

Comment 3

[Ed Lee :Mardak]

I can't seem to reproduce this following those steps. This must be an exthandler download for the save-file/open-with prompt because save-link-as would have you explicitly choose the download name.

I was able to download exe files (on os x) that use the simplified dialog..
firefox-3.0a9pre.en-US.win32.installer.exe
firefox-3.0a9pre.en-US.win32.installer(2).exe

as well as the full dialog with "save file"..
Firefox 2.0.0.8.dmg
Firefox 2.0.0.8(2).dmg

(In reply to comment #0)
> then refreshing and clicking "Save As..."
Did you mean "Save file"? The exthandler dialog has "open with" and "save file".

Comment 4

[Stephen Donner [:stephend] Not actively reading bugmail]

(In reply to comment #3)
> I can't seem to reproduce this following those steps. This must be an
> exthandler download for the save-file/open-with prompt because save-link-as
> would have you explicitly choose the download name.

Yes, it is, sorry.
 
> I was able to download exe files (on os x) that use the simplified dialog..
> firefox-3.0a9pre.en-US.win32.installer.exe
> firefox-3.0a9pre.en-US.win32.installer(2).exe
> 
> as well as the full dialog with "save file"..
> Firefox 2.0.0.8.dmg
> Firefox 2.0.0.8(2).dmg
> 
> (In reply to comment #0)
> > then refreshing and clicking "Save As..."
> Did you mean "Save file"? The exthandler dialog has "open with" and "save
> file".

I did indeed; sorry for the typo.  I can't reproduce on Windows (Vista or XP), or Linux, so not sure what's going on with my Mac; I'll ask around and see if anyone else here (QA) can reproduce.

Comment 5

[:Gavin Sharp [email: [e-mail]]]

I can't reproduce, using Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9a9pre) Gecko/2007103104 Minefield/3.0a9pre .

The second file downloads fine, to Firefox 2.0.0.8(2).dmg.

Comment 6

[Stephen Donner [:stephend] Not actively reading bugmail]

This also Just Works (tm) for Ben Hearsum, so I'm not sure we really want to block, but we (I) should investigate why this isn't working for my build; I'm going to try with a new profile.

Comment 7

[Stephen Donner [:stephend] Not actively reading bugmail]

A new profile completely fixed this for me (!)

Comment 8

[Ed Lee :Mardak]

Should this be WFM per comments 5-7?

I suppose just to check, you could try copying your downloads.sqlite file from the old profile to the new one.

Comment 9

[Stephen Donner [:stephend] Not actively reading bugmail]

(In reply to comment #8)
> Should this be WFM per comments 5-7?
> 
> I suppose just to check, you could try copying your downloads.sqlite file from
> the old profile to the new one.

It should be; I no longer have the file, sadly, because I was an idiot and deleted it, rather than just saving it off...

I'm scared of touching the flags, so I'll let other folks do that :-)