Closed Bug 401893 Opened 17 years ago Closed 17 years ago

make sure that the Larry button is as high as the location bar

Categories

(Firefox :: Address Bar, defect)

x86
All
defect
Not set
normal

Tracking

()

VERIFIED FIXED
Firefox 3 beta1

People

(Reporter: dao, Assigned: dao)

References

Details

Attachments

(1 file)

Attached patch patchSplinter Review
If the location bar is higher than usual (for instance add style="font-size:2em" to #urlbar via DOMi), and if the Larry button doesn't have a label (i.e. Identity unknown), the button isn't as high as the whole location bar.
Attachment #286836 - Flags: review?(mano)
Blocks: larry
No longer blocks: 395248
Comment on attachment 286836 [details] [diff] [review] patch i guess... r=mano. What about pinstripe?
Attachment #286836 - Flags: review?(mano) → review+
Based on current styling (e.g. the endcaps, http://mxr.mozilla.org/mozilla/source/browser/themes/pinstripe/browser/Go.png), I don't think Pinstripe supports or needs to support bigger text in the Location and Search bar.
Attachment #286836 - Flags: approvalM9?
Comment on attachment 286836 [details] [diff] [review] patch a=endgame drivers for M9
Attachment #286836 - Flags: approvalM9? → approvalM9+
Keywords: checkin-needed
Checking in browser/themes/winstripe/browser/browser.css; /cvsroot/mozilla/browser/themes/winstripe/browser/browser.css,v <-- browser.css new revision: 1.111; previous revision: 1.110 done
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Keywords: checkin-needed
OS: Windows XP → All
Resolution: --- → FIXED
Target Milestone: --- → Firefox 3 M9
v. Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9a9pre) Gecko/2007110610 Minefield/3.0a9pre
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: