401953 - Move work_time validation from process_bug to Bugzilla::Bug

Status: RESOLVED FIXED

(Bugzilla :: Creating/Changing Bugs, enhancement)

Description

[Max Kanat-Alexander]

This is part of adding a comment, really, at this point, so that's how it's going to have to work.

Comment 1

[Max Kanat-Alexander]

Okay, so work_time is already actually updated in Bugzilla::Bug, but there's just a bit of validation that has to be moved into process_bug--the part that checks that a comment has actually been made.

Comment 2

[Max Kanat-Alexander]

Attachment: v1

This is pretty straightforward. I tested it and it works.

Comment 3

[Frédéric Buclin]

Comment on attachment 286893 [details] [diff] [review]
v1

>+++ process_bug.cgi

>-# Validate work_time
>-if (defined $cgi->param('work_time') 
>-    && $cgi->param('work_time') ne $cgi->param('dontchange')) 

You are lucky that you cannot edit work_time when editing several bugs at once. Else you could pass --do-not-change-- to _check_time() and it would complain.


>         $bug_objects{$id}->add_comment(scalar($cgi->param('comment')),
>             { isprivate => scalar($cgi->param('commentprivacy')),
>-              work_time => $work_time, type => $type, 
>+              work_time => scalar $cgi->param('work_time'), type => $type, 
>               extra_data => $duplicate});

Nit: type => $type could now be on its own line.


Your patch seems to work correctly, even when editing several bugs at once. The bug I found while testing your patch is unrelated to it, so that's fine. ;) r=LpSolit

Comment 4

[Max Kanat-Alexander]

Checking in process_bug.cgi;
/cvsroot/mozilla/webtools/bugzilla/process_bug.cgi,v  <--  process_bug.cgi
new revision: 1.392; previous revision: 1.391
done
Checking in Bugzilla/Bug.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/Bug.pm,v  <--  Bug.pm
new revision: 1.213; previous revision: 1.212
done