401971 - create Firefox-specific module on mxr.mozilla.org

Status: RESOLVED FIXED

(mozilla.org Graveyard :: Server Operations, task)

Description

[Myk Melez [:myk] [@mykmelez]]

Searching on MXR for Firefox code generally requires wading through a bunch of non-Firefox code.  For example, this search for "Save Page As" in the SeaMonkey module returns results in extensions/manticore/, editor/, suite/, and embedding/ in addition to browser/:

http://mxr.mozilla.org/seamonkey/search?string=save+page+as&find=&findi=&filter=&tree=seamonkey

It would be useful for Firefox developers if there was a MXR module containing just Firefox code.

Comment 1

[Reed Loden [:reed]]

What CVS module does client.mk pull when you just have MOZ_CO_PROJECT=browser?

Comment 2

[:Gavin Sharp [email: [e-mail]]]

client.mk doesn't use a module, it explicitly lists directories.

Comment 3

[Dave Miller [:justdave]]

MXR's checkout script is pretty flexible.  Basically, if we can make it check out just what we need from the command line, the updater script can be made to follow suit.  I've set up a checkout following the directions at http://developer.mozilla.org/en/docs/Mozilla_Source_Code_%28CVS%29#Selecting_a_Project_to_Pull with MOZ_CO_PROJECT=browser

http://mxr.mozilla.org/firefox/source/   <-- trunk updated hourly at 40 minutes
                                             past the hour
http://mxr.mozilla.org/firefox2/source/  <-- MOZILLA_1_8_BRANCH updated daily
                                             at 10:10am pacific

Comment 4

[Myk Melez [:myk] [@mykmelez]]

This doesn't work quite right yet.  Taking a string search for "save page as" as an example, the SeaMonkey module returns 17 results:

http://mxr.mozilla.org/seamonkey/search?string=save+page+as

The Firefox trunk module returns 13 results:

http://mxr.mozilla.org/firefox/search?string=save+page+as

It doesn't include the four results in "suite", which is an improvement, but it does include a bunch of stuff that isn't part of Firefox, like /xpfe/communicator/resources/content/contentAreaUtils.js (Firefox uses the version of that file in toolkit) and files in extensions/, editor/, and embedding/.

The Firefox2 module returns 21 results, including files in extensions/p3p and embedding/minimo that aren't part of Firefox 2.

http://mxr.mozilla.org/firefox2/search?string=save+page+as

Dave, do you want to reopen this bug, or shall I file a new bug on this issue?

Comment 5

[:Gavin Sharp [email: [e-mail]]]

Any bug you file on MXR having an accurate index of files Firefox actually uses will depend on a bug about client.mk only checking out files that Firefox actually uses. Maybe you should file that second bug first, and see what bsmedberg has to say about it.

Comment 6

[Dave Miller [:justdave]]

Yeah, what gavin said.  If it's finding stuff it shouldn't be finding, it means client.mk is checking it out.

For reference, the updater script is doing this:

make -C mozilla -f client.mk pull_all MOZ_CO_PROJECT=browser

And each of the trees was initially created by checking out mozilla/client.mk and mozilla/browser/config/mozconfig from the trunk in the firefox tree and from the MOZILLA_1_8_BRANCH in the firefox2 tree.

Because of the way the checkout works, you might need me to reset the checkouts after client.mk is fixed to only pull the correct files, in order to get rid of the old stuff.