402000 - imgContainer's ContainerLoader.mContainer should be a nsCOMPtr

Status: RESOLVED FIXED

(Core :: Graphics: ImageLib, defect)

Description

[Justin Dolske [:Dolske]]

Attachment: Patch for review, v.1

I cut'n'paste this code for use elsewhere, and ended up crashing because of it. It doesn't seem to be crashing for how imgContainer uses it, so I'm not sure what's up with that.

Comment 1

[Stuart Parmenter]

Comment on attachment 286940 [details] [diff] [review]
Patch for review, v.1

this could lead to nasty crashes. we should land this for m9

Comment 2

[Michael Ventnor]

This blocks beta so no need for approval to land.

Comment 3

[Reed Loden [:reed]]

(In reply to comment #2)
> This blocks beta so no need for approval to land.

Actually, it doesn't block the beta right now. dolske set the TM when he filed it (instead of one of the end-game drivers). Now, the end-game drivers may wish for it to be a beta blocker...

Comment 4

[Justin Dolske [:Dolske]]

Checking in modules/libpr0n/src/imgContainer.cpp;
/cvsroot/mozilla/modules/libpr0n/src/imgContainer.cpp,v  <--  imgContainer.cpp
new revision: 1.59; previous revision: 1.58

Comment 5

[Marcia Knous [:marcia]]

Justin: QA could use some help as to how to verify this bug. Thanks.

Comment 6

[Justin Dolske [:Dolske]]

I'm not sure it's really possible to externally verify this, and it's probably an obvious/simple enough change that it's not worth the effort to do so...